[FIX] Windows: Correctly handle project paths containing non-ASCII characters #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
force-pushed
the
no-slash
branch
2 times, most recently
from
9e2c9e3 to
e9c0f20
Compare
matz3
previously approved these changes
Dec 16, 2020
…aracters The `slash` module does not convert "extended-length" paths or paths which contain non-ASCII characters as documented in the modules README: https://github.com/sindresorhus/slash/blob/7a9158487d8046c13f2de1db7e3734d33bdbb1bd/readme.md#slash- Since in our case the resulting POSIX paths are only used in our virtual fs "@ui5/fs", these limitations are not relevent to us. Therefore we can simply replace any backslashes. Related to SAP/ui5-fs#294 Resolves SAP/ui5-tooling#469
RandomByte
force-pushed
the
no-slash
branch
2 times, most recently
from
ded4f17 to
219eb14
Compare
|
Still missing: non-ASCII tests for ApplicationFormatter |
RandomByte
force-pushed
the
no-slash
branch
2 times, most recently
from
90af877 to
6f36482
Compare
|
Confirmed that the LibraryFormatter tests would fail on Windows without the fix in https://dev.azure.com/sap/opensource/_build/results?buildId=115046&view=results |
matz3
previously approved these changes
Dec 17, 2020
…on-ASCII characters
…non-ASCII characters
|
Now finally ready 🙂 |
matz3
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
slashmodule does not convert "extended-length" paths or pathswhich contain non-ASCII characters as documented in the modules README:
https://github.com/sindresorhus/slash/blob/7a9158487d8046c13f2de1db7e3734d33bdbb1bd/readme.md#slash-
Since in our case the resulting POSIX paths are only used in our virtual
fs "@ui5/fs", these limitations are not relevent to us.
Therefore we can simply replace any backslashes.
Related to SAP/ui5-fs#294
Resolves SAP/ui5-tooling#469