[FEATURE] Add config command #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: The build would fail until we merge and make a release of: SAP/ui5-project#575 |
RandomByte
reviewed
Apr 18, 2023
flovogt
requested changes
Apr 19, 2023
d3xter666
force-pushed
the
add-configuration-cli
branch
from
83ad93a to
309aaea
Compare
RandomByte
force-pushed
the
add-configuration-cli
branch
from
309aaea to
b475a40
Compare
flovogt
reviewed
Apr 21, 2023
flovogt
previously approved these changes
Apr 21, 2023
RandomByte
force-pushed
the
add-configuration-cli
branch
2 times, most recently
from
21949aa to
92e29ba
Compare
* No help is printed on yargs errors, so do not refer to it (also see #256) * Only mention 'ui5 --help'
* Fix 'ui5 set <key>' without value or empty string to unset * Log everything to stderr, except machine parsable output like configuration values returned by 'ui5 list' and 'ui5 get <key>' * Do not mention location of ui5rc in config commands. In the future we might have multiple locations and @ui5/project/config/Configuration would take care of deciding where to read what from. The CLI should not have that knowledge * Move imports and variable definitions to handler in order to only execute them if the command is actually 'ui5 config' * Tests now mock Configuration in order to not modify the actual configuration of the user running the tests
d3xter666
force-pushed
the
add-configuration-cli
branch
from
92e29ba to
22cd468
Compare
matz3
reviewed
Apr 24, 2023
| const command = commandArgs[commandArgs.length - 1]; | ||
|
|
||
| const {default: Configuration} = await import( "@ui5/project/config/Configuration"); | ||
| const allowedKeys = ["mavenSnapshotEndpointUrl"]; |
There was a problem hiding this comment.
Shouldn't this information come from the Configuration class instead of hard-code it here?
It would allow us to add new options without having to adjust the CLI project.
There was a problem hiding this comment.
True. That's a good idea we should follow-up on 👍
RandomByte
force-pushed
the
add-configuration-cli
branch
from
f106971 to
19122b5
Compare
KlattG
suggested changes
Apr 25, 2023
Co-authored-by: Günter Klatt <[email protected]>
RandomByte
force-pushed
the
add-configuration-cli
branch
from
5b14dad to
04fdf8d
Compare
matz3
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature depends on SAP/ui5-project#575
and makes the enablement of
mavenSnapshotEndpointUrleasier: SAP/ui5-project#570