Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Fix resources tests #466

Merged
merged 1 commit into from
Jan 9, 2023
Merged

[INTERNAL] Fix resources tests #466

merged 1 commit into from
Jan 9, 2023

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Jan 4, 2023

Some tests didn't use the corresponding adapter, which caused
race-conditions as both adapter tests used the FileSystem adapter.

It is now ensured that all tests use the right adapter.

Follow-up of #448

Some tests didn't use the corresponding adapter, which caused
race-conditions as both adapter tests used the FileSystem adapter.

It is now ensured that all tests use the right adapter.

Follow-up of #448
@coveralls
Copy link

Coverage Status

Coverage: 89.064% (+0.2%) from 88.898% when pulling c3a116d on fix-resources-test into 9607384 on main.

@matz3 matz3 requested a review from a team January 4, 2023 13:11
Copy link
Member

@flovogt flovogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this follow-up.

@matz3 matz3 merged commit 4f600d1 into main Jan 9, 2023
@matz3 matz3 deleted the fix-resources-test branch January 9, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants