[FIX] Validator contructor checks (#567)

Validate schemaName properly based on the enum by fixing a typo in tests & correcting the logical expression
SAP · Feb 7, 2023 · 292b454 · 292b454
1 parent f981d62
commit 292b454
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/validation/validator.js b/lib/validation/validator.js
@@ -19,7 +19,7 @@ export const SCHEMA_VARIANTS = {
 
 class Validator {
 	constructor({Ajv, ajvErrors, schemaName}) {
-		if (!schemaName && !SCHEMA_VARIANTS[schemaName]) {
+		if (!schemaName || !SCHEMA_VARIANTS[schemaName]) {
 			throw new Error(
 				`"schemaName" is missing or incorrect. The available schemaName variants are ${Object.keys(
 					SCHEMA_VARIANTS

diff --git a/test/lib/validation/validator.js b/test/lib/validation/validator.js
@@ -88,7 +88,7 @@ test("Validator requires a valid schemaName", (t) => {
 	const Ajv = sinon.stub();
 	const ajvErrors = sinon.stub();
 	const invalidContructor = () => {
-		new Validator({Ajv, ajvErrors, schemName: "invalid schema name"});
+		new Validator({Ajv, ajvErrors, schemaName: "invalid schema name"});
 	};
 
 	t.throws(invalidContructor, {