Skip to content

Commit

Permalink
projectGraphBuilder: Fix check for already qualified application proj…
Browse files Browse the repository at this point in the history
…ects

If the already qualified project is visited again, it should not be
skipped but handled like any other duplicate. This change is mainly to
prevent the irritating log message indicating that the same project
already qualified as the application project but is ignored.
  • Loading branch information
RandomByte committed Feb 23, 2021
1 parent 43f27c9 commit c5b264e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions lib/graph/ProjectGraph.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ class ProjectGraph {
throw new Error(
`Failed to add project ${projectName} to graph: Project name must not be integer-like`);
}
log.verbose(`Adding project: ${projectName}`);
this._projects[projectName] = project;
this._adjList[projectName] = [];
this._optAdjList[projectName] = [];
Expand Down
4 changes: 2 additions & 2 deletions lib/graph/projectGraphBuilder.js
Original file line number Diff line number Diff line change
Expand Up @@ -199,12 +199,12 @@ module.exports = async function(nodeProvider) {
if (!qualifiedApplicationProject) {
log.verbose(`Project ${projectName} qualified as application project for project graph`);
qualifiedApplicationProject = project;
} else if (!(qualifiedApplicationProject.getName() === projectName && node.deduped)) {
} else if (qualifiedApplicationProject.getName() !== projectName) {
// Project is not a duplicate of an already qualified project (which should
// still be processed below), but a unique, additional application project

// TODO: Should this rather be a verbose logging?
// projectPreprocessor handled this like any project that got ignored for some reason and did a
// projectPreprocessor handled this like any project that got ignored and did a
// (in this case misleading) general verbose logging:
// "Ignoring project with missing configuration"
log.info(
Expand Down

0 comments on commit c5b264e

Please sign in to comment.