Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] projectPreprocessor: Add handling for server-middleware extensions #190

Merged
merged 1 commit into from
Jul 11, 2019
Merged

[FEATURE] projectPreprocessor: Add handling for server-middleware extensions #190

merged 1 commit into from
Jul 11, 2019

Conversation

RandomByte
Copy link
Member

As per RFC 0005: SAP/ui5-tooling#151

@RandomByte RandomByte requested a review from Thodd June 25, 2019 14:14
@RandomByte RandomByte mentioned this pull request Jun 25, 2019
Merged
@RandomByte RandomByte force-pushed the server-middleware-extensibility branch from 6630d97 to 22040f4 Compare June 25, 2019 15:17
@RandomByte
Copy link
Member Author

Depends on SAP/ui5-server#200

@RandomByte RandomByte force-pushed the server-middleware-extensibility branch from 22040f4 to aa26ec8 Compare July 10, 2019 12:54
@coveralls
Copy link

coveralls commented Jul 10, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 83.333% when pulling ba819f9 on server-middleware-extensibility into db573f0 on master.

Thodd
Thodd previously approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@Thodd Thodd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 0.05% coverage delta considered an issue?
Sounds a bit harsh to me...

@RandomByte RandomByte force-pushed the server-middleware-extensibility branch from aa26ec8 to ba819f9 Compare July 11, 2019 09:47
@RandomByte
Copy link
Member Author

rebased

@RandomByte RandomByte requested a review from Thodd July 11, 2019 09:50
@RandomByte RandomByte merged commit 2ce964c into master Jul 11, 2019
@RandomByte RandomByte deleted the server-middleware-extensibility branch July 11, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thodd Thodd Thodd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RandomByte @coveralls @Thodd