[BREAKING] Transform module to ESM #472

matz3 · 2022-09-14T14:20:30Z

JIRA: CPOUI5FOUNDATION-525

It seems like the combination {@ is treated somehow specially in jsdoc and it could not not map the annotation to the definitions and could not create the links properly. Adding a space between them solves the issue.

flovogt

part 1: implementation reviewed.
review of tests will follow later today

lib/build/TaskRunner.js

lib/build/definitions/_utils.js

lib/build/definitions/application.js

lib/specifications/types/Application.js

lib/specifications/types/Library.js

lib/ui5Framework/AbstractResolver.js

lib/validation/validator.js

flovogt

part 2: tests

test/lib/build/definitions/utils.js

test/lib/graph/graphFromObject.js

test/lib/package-exports.js

test/utils/AjvCoverage.js

test/lib/graph/graphFromObject.js

coveralls · 2022-10-24T14:07:33Z

Coverage increased (+0.1%) to 94.615% when pulling 8ec6c9a on esm into aa7f366 on next.

matz3 changed the title ~~[WIP][BREAKING] Transform module to ESM~~ [BREAKING] Transform module to ESM Oct 5, 2022

RandomByte force-pushed the esm branch from c691b27 to 3440f34 Compare October 7, 2022 13:37

matz3 and others added 28 commits October 20, 2022 16:22

Update testing dependencies for ESM, fix ESLint / JSDoc

974282e

Transform lib/

20e0ffd

Transform test/

9d11bcc

Start fixing tests

0cf4cae

fix ProjectBuilder.js

d48d6de

Start fixing validation tests

774cd31

Fix validation tests

263123e

Fix ui5Framework tests

6240a18

Fix specifiction tests

bd08478

fix: test/lib/build/TaskRunner.js

e735599

wip builder and graph

a793102

continue build and graph

c815bb5

wip

ca4b27a

Specifictation: Properly test create factory

55f4fe3

Fix Library specification tests

7e538d4

Fix ui5Framework.integration.js test

8c684a0

Fix more tests

9f01f20

Continue fixing TaskRunner

c5da914

Fix TaskRunner test

17cd247

Fix build/helpers/createBuildManifest

a121a3c

Fix composeProjectList test and add missing test case

2958e11

Fix more tests

de83d20

Fix all tests

73208b3

Define package exports

7bcec61

Fix jsdoc build

a3c1f81

Start updating JSDoc for ESM imports

aabf57b

Export generateProjectGraph as graph API

0e70725

Adopt graph.js to use named exports with new names

341b079

matz3 and others added 14 commits October 20, 2022 16:22

Adapt to new async APIs

749a56c

TaskRunner: standardTasks must be provided

27fa989

Update test names

a6928c5

Ehance tests for CJS/ESM extensions

3b7b6fc

jsdoc: part1

4f4e5b8

JSDoc comments

e513938

JSDoc: Change notations from . to /

30b93ea

JSDoc: Make annotations to modules mappable for jsdoc

3513550

It seems like the combination {@ is treated somehow specially in jsdoc and it could not not map the annotation to the definitions and could not create the links properly. Adding a space between them solves the issue.

JSDOC: build,specifications and smaller fixes

2a6496d

JSDoc: fix build,graph

90e3473

JSDoc: enable jsdoc plugin

b76bbfe

JSDoc: smaller fixes

f2e7e83

fix 'fs/resourceFactory imports'

6f735b8

fix: add missing await

c9b44bd

RandomByte force-pushed the esm branch from eb3c4d2 to c9b44bd Compare October 20, 2022 14:22

flovogt requested changes Oct 21, 2022

View reviewed changes

test/lib/build/definitions/utils.js Outdated Show resolved Hide resolved

test/lib/graph/graphFromObject.js Show resolved Hide resolved

test/lib/package-exports.js Show resolved Hide resolved

test/utils/AjvCoverage.js Outdated Show resolved Hide resolved

code smells and smaller refactorings

c6d9c0f

flovogt force-pushed the esm branch from 94110ad to c6d9c0f Compare October 24, 2022 05:35

RandomByte previously approved these changes Oct 24, 2022

View reviewed changes

test/lib/graph/graphFromObject.js Show resolved Hide resolved

flovogt dismissed RandomByte’s stale review via ed265ee October 24, 2022 13:30

Temporary use @ui5/builder esm branch

60898d4

flovogt force-pushed the esm branch from ed265ee to 60898d4 Compare October 24, 2022 14:05

flovogt previously approved these changes Oct 24, 2022

View reviewed changes

fix imports for windows

8ec6c9a

flovogt dismissed their stale review via 8ec6c9a October 24, 2022 14:17

flovogt approved these changes Oct 24, 2022

View reviewed changes

flovogt merged commit 1945f2e into next Oct 24, 2022

flovogt deleted the esm branch October 24, 2022 14:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BREAKING] Transform module to ESM #472

[BREAKING] Transform module to ESM #472

matz3 commented Sep 14, 2022

flovogt left a comment

flovogt left a comment

coveralls commented Oct 24, 2022 •

edited

Loading

[BREAKING] Transform module to ESM #472

[BREAKING] Transform module to ESM #472

Conversation

matz3 commented Sep 14, 2022

flovogt left a comment

Choose a reason for hiding this comment

flovogt left a comment

Choose a reason for hiding this comment

coveralls commented Oct 24, 2022 • edited Loading

coveralls commented Oct 24, 2022 •

edited

Loading