-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] ProjectBuilder: Add outputStyle
option to request flat build output
#624
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
f1c61c9
[FEATURE] ProjectBuilder: Add option to request flat build output
RandomByte eaa70e6
[INTERNAL] BuildContext: Do not allow flat build output for theme-lib…
RandomByte 0413d30
Add flatOutput to the ProjectGraph's build dependencies
d3xter666 3961054
Handle flatOutput default value and errors
d3xter666 3005524
Add JSDoc for application type for flatOutput
d3xter666 92cb9c9
Enhance tests for type=application
d3xter666 48e1877
Log skipped files when doing flat output
d3xter666 3d8133a
Refactor
d3xter666 5d352cc
Fix tests
d3xter666 525113d
Skip checks for flat project types
d3xter666 eb9fb41
Adjust docs
d3xter666 e4f542c
Migrate boolean flag for flat output to enum
d3xter666 aa1d4be
Fix jsdoc issues
d3xter666 2607525
JSDoc adjustments
d3xter666 8008da1
Start using "real" Enum for output style
d3xter666 0f2bf86
Enable Namespaced builds for applications
d3xter666 57b3513
Enhance tests to support application's namespaced build
d3xter666 d8fb285
Apply output styles only for the root project
d3xter666 4f1e754
Validate unsupported combinations of project type & output style
d3xter666 7487618
Enhance tests for the new behaviour
d3xter666 51e22f1
Update lib/build/ProjectBuilder.js
d3xter666 76635e3
Update lib/build/ProjectBuilder.js
d3xter666 e844df3
Update lib/build/helpers/BuildContext.js
d3xter666 f1e6ed4
Update lib/build/helpers/BuildContext.js
d3xter666 74f5204
Update lib/build/helpers/ProjectBuilderOutputStyle.js
d3xter666 ac1877d
Update lib/build/helpers/ProjectBuilderOutputStyle.js
d3xter666 f7f1862
JSDoc adjustments
d3xter666 5890943
Fix JSDocs & Tests
d3xter666 577696f
Update lib/build/helpers/ProjectBuilderOutputStyle.js
d3xter666 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
/** | ||
* Processes build results into a specific directory structure. | ||
* | ||
* @public | ||
* @readonly | ||
* @enum {string} | ||
* @property {string} Default The default directory structure for every project type. | ||
* For applications this is identical to "Flat" and for libraries to "Namespace". | ||
* Other types have a more distinct default output style. | ||
* @property {string} Flat Omits the project namespace and the "resources" directory. | ||
* @property {string} Namespace Respects project namespace and the "resources" directory. | ||
* @module @ui5/project/build/ProjectBuilderOutputStyle | ||
*/ | ||
export default { | ||
Default: "Default", | ||
Flat: "Flat", | ||
Namespace: "Namespace" | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These string variable names are in uppercase - do we have any guidelines which case to use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the same as the following module we already have: https://github.com/SAP/ui5-project/blob/main/lib/ui5Framework/maven/CacheMode.js
Basically, those are enums and they are expected to start with a capital letter. It's actually a workaround we use as JavaScript does not have native Enum type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack