Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] ProjectBuilder: Add
outputStyle
option to request flat build output #624[FEATURE] ProjectBuilder: Add
outputStyle
option to request flat build output #624Changes from 20 commits
f1c61c9
eaa70e6
0413d30
3961054
3005524
92cb9c9
48e1877
3d8133a
5d352cc
525113d
eb9fb41
e4f542c
aa1d4be
2607525
8008da1
0f2bf86
57b3513
d8fb285
4f1e754
7487618
51e22f1
76635e3
e844df3
f1e6ed4
74f5204
ac1877d
f7f1862
5890943
577696f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These string variable names are in uppercase - do we have any guidelines which case to use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the same as the following module we already have: https://github.com/SAP/ui5-project/blob/main/lib/ui5Framework/maven/CacheMode.js
Basically, those are enums and they are expected to start with a capital letter. It's actually a workaround we use as JavaScript does not have native Enum type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack