-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INTERNAL] Improve documentation after code refactoring #874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…sks (#628) This change allows custom tasks to subscribe to any standard task, even disabled ones, ensuring custom tasks' execution and the correct order. Background information: When transitioning a project from V2 to V3, we often need to adjust the before/after task assignments for custom tasks due to the removal of the `uglify` task. The new `minify` task now runs earlier than the previous `uglify` task. Developers typically used `uglify` as the last enabled standard task to subscribe to. You can find updated documentation here: SAP/ui5-tooling#874 JIRA: CPOUI5FOUNDATION-724 --------- Co-authored-by: Yavor Ivanov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor points.
Co-authored-by: Günter Klatt <[email protected]>
Co-authored-by: Günter Klatt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion.
Addresses the outstanding comments from this PR: #874 #874 (comment)
JIRA: CPOUI5FOUNDATION-724
This PR aims to improve the documentation by providing correct information based on a related change for custom tasks subscription & execution order behaviour: SAP/ui5-project#628