Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(AnalyticalTable): migrate from react-jss to css modules #5701

Merged
merged 5 commits into from
Apr 12, 2024
Merged

refactor(AnalyticalTable): migrate from react-jss to css modules #5701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d4f8fdf
[ci chromatic]
Lukas742 Apr 11, 2024
c832e4c
temp: allow chromatic [ci chromatic]
Lukas742 Apr 11, 2024
872d99b
refactor [ci chromatic]
Lukas742 Apr 11, 2024
d3ac3d9
fix selection styles
Lukas742 Apr 11, 2024
5853e55
Update AnalyticalTable.stories.tsx
Lukas742 Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
312 changes: 312 additions & 0 deletions packages/main/src/components/AnalyticalTable/AnalyticalTable.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,312 @@
.table {
position: relative;
width: 100%;
max-width: 100%;
overflow-y: hidden;
overflow-x: auto;
height: 100%;
min-height: 3rem;
font-family: var(--sapFontFamily);
font-size: var(--sapFontSize);
font-weight: normal;
background-color: var(--sapList_Background);

/* bottom border*/
&::after {
content: '';
position: absolute;
inset-block-end: 0;
inset-inline-start: 0;
height: 1px;
width: 100%;
background: var(--sapList_TableFooterBorder);
}
}

.tableContainerWithScrollBar {
position: relative;
}

.overlay {
position: absolute;
z-index: 1;
top: 0;
bottom: 0;
left: 0;
right: 0;
MarcusNotheis marked this conversation as resolved.
Show resolved Hide resolved
background: var(--sapGroup_ContentBackground);
opacity: 0.8;

&:focus {
outline-offset: calc(-1 * var(--sapContent_FocusWidth));
outline: var(--sapContent_FocusWidth) var(--sapContent_FocusStyle) var(--sapContent_FocusColor);
}
}

.tableHeaderRow {
height: var(--_ui5wcr-AnalyticalTableHeaderRowHeight);

div:first-child .th {
border-inline-start: 1px solid var(--sapList_BorderColor);
}
}

.hasNavigationIndicator {
.tableHeaderRow :nth-last-child(2) .th {
border-inline-end: none;
}

.tr :nth-last-child(2) {
border-inline-end: none;
}
}

.tableHeaderBackgroundElement {
box-sizing: border-box;
position: absolute;
inset-inline: 0;
height: var(--_ui5wcr-AnalyticalTableHeaderRowHeight);
background-color: var(--sapList_HeaderBackground);
border-block-start: var(--_ui5wcr-AnalyticalTable-OuterBorderBlock);
border-block-end: var(--_ui5wcr-AnalyticalTable-HeaderBorderWidth) solid var(--sapList_HeaderBorderColor);
}

.tableBodyBackgroundElement {
box-sizing: border-box;
position: absolute;
inset-inline: 0;
inset-block-end: 0;
border-block-end: 1px solid var(--sapList_TableFooterBorder);
}

.th {
height: var(--_ui5wcr-AnalyticalTableHeaderRowHeight);
color: var(--sapList_HeaderTextColor);
background-color: var(--sapList_HeaderBackground);
border-block-start: var(--_ui5wcr-AnalyticalTable-OuterBorderBlock);
border-block-end: var(--_ui5wcr-AnalyticalTable-HeaderBorderWidth) solid var(--sapList_HeaderBorderColor);
border-inline-end: 1px solid var(--sapList_BorderColor);
padding-inline: 0.5rem;
text-align: start;
box-sizing: border-box;

&:hover {
background-color: var(--sapList_Hover_Background);
color: var(--_ui5wcr-AnalyticalTable-HeaderActiveTextColor);
}

&:active {
background-color: var(--sapList_Active_Background);
color: var(--_ui5wcr-AnalyticalTable-HeaderActiveTextColor);
}

&[data-column-id='__ui5wcr__internal_highlight_column'] {
border-inline-end: 1px solid transparent;
}

&:last-child [data-resizer] {
transform: translateX(0px);
}

&:focus {
&[data-column-id='__ui5wcr__internal_selection_column'] {
border-inline-start: 1px solid transparent;
}
outline-offset: calc(-1 * var(--sapContent_FocusWidth));
outline: var(--sapContent_FocusWidth) var(--sapContent_FocusStyle) var(--sapContent_FocusColor);
}
}

.tbody {
position: relative;
overflow-x: hidden;
overflow-y: auto;
scrollbar-width: none;
box-sizing: border-box;
-ms-overflow-style: none;

&::-webkit-scrollbar {
width: 0 !important;
height: 0 !important;
display: none !important;
}
}

.alternateRowColor {
background-color: var(--sapList_AlternatingBackground);
}

.tr {
position: absolute;
inset-block-start: 0;
inset-inline-start: 0;
width: 100%;
color: var(--sapList_TextColor);
border-block-end: 1px solid var(--sapList_BorderColor);
/* needed for vertical virtualization*/
margin-bottom: -1px;
box-sizing: border-box;
display: flex;

&:hover:not([data-empty-row]) {
background-color: var(--sapList_Hover_Background);
}

&[data-is-selected] {
border-block-end: 1px solid var(--sapList_SelectionBorderColor);
background-color: var(--sapList_SelectionBackgroundColor);
}

&[data-is-selected]:hover {
background-color: var(--sapList_Hover_SelectionBackground);
}
}

.trActive {
cursor: pointer;
}
MarcusNotheis marked this conversation as resolved.
Show resolved Hide resolved

.tableGroupHeader.tr {
font-family: var(--_ui5wcr-AnalyticalTable-HeaderFontFamily);
background-color: var(--sapList_TableGroupHeaderBackground);
border-color: var(--sapList_TableGroupHeaderBorderColor);
color: var(--sapList_TextColor);

.tableCell {
border-inline-end: 1px solid transparent;
}
}

.tableText {
display: inline-block;
font-size: var(--sapFontSize);
max-width: 100%;
box-sizing: border-box;
font-weight: normal;
overflow: hidden;
word-wrap: normal;
white-space: nowrap;
text-overflow: ellipsis;
}

.tableCell {
position: relative;
height: 100%;
box-sizing: border-box;
border-inline-end: 1px solid var(--sapList_BorderColor);
display: inline-flex;
padding: 0 0.5rem;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
align-items: center;

&:first-child {
border-inline-start: var(--_ui5wcr-AnalyticalTable-OuterCellBorder);
}

&:last-child {
border-inline-end: var(--_ui5wcr-AnalyticalTable-OuterCellBorder);
}

&:focus {
outline-offset: calc(-1 * var(--sapContent_FocusWidth));
outline: var(--sapContent_FocusWidth) var(--sapContent_FocusStyle) var(--sapContent_FocusColor);

&[data-empty-row-cell] {
outline: none;
}
}
}

.showVerticalEndBorder .tableCell {
border-inline-end: 1px solid var(--sapList_BorderColor);
}

.noDataContainer {
display: flex;
justify-content: center;
align-items: center;
height: 100%;
background-color: var(--sapList_Background);
width: 100%;
box-sizing: border-box;
color: var(--sapList_TextColor);
font-family: var(--sapFontFamily);
font-size: var(--sapFontSize);
font-weight: normal;
border-block-end: 1px solid var(--sapList_BorderColor);
}

.success {
background-color: var(--sapSuccessColor);
}

.error {
background-color: var(--sapErrorColor);
}

.warning {
background-color: var(--sapWarningColor);
}

.information {
background-color: var(--sapInformationColor);
}

.indication01 {
background: var(--sapIndicationColor_1);
}

.indication02 {
background: var(--sapIndicationColor_2);
}

.indication03 {
background: var(--sapIndicationColor_3);
}

.indication04 {
background: var(--sapIndicationColor_4);
}

.indication05 {
background: var(--sapIndicationColor_5);
}

.indication06 {
background: var(--sapIndicationColor_6);
}

.indication07 {
background: var(--sapIndicationColor_7);
}

.indication08 {
background: var(--sapIndicationColor_8);
}

.hiddenSmartColMeasure {
visibility: hidden;
position: fixed;
white-space: nowrap;
height: 0;
}

.hiddenSmartColMeasureHeader {
font-family: var(--_ui5wcr-AnalyticalTable-HeaderFontFamily);
}

.hiddenA11yText {
display: none;
}

.checkBox::part(root) {
display: flex;
width: unset;
height: unset;
justify-content: center;
min-height: unset;
min-width: unset;
padding: 0;
}
2 changes: 1 addition & 1 deletion packages/main/src/components/AnalyticalTable/AnalyticalTable.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ export const DynamicRowCount = {
<>
<Button onClick={handleClick}>Toggle Number of Rows</Button>
<br />
<Text>Number of visible rows: {args.data.length}</Text>
<Text>Number of visible rows: {data.length}</Text>
<hr />
<div style={{ height: `${args.containerHeight}px` }}>
<AnalyticalTable
Expand Down
Loading
Loading