refactor(ui5-switch): subscribe event handlers within HBS template (#955

)
SAP · Nov 21, 2019 · 1a5903e · 1a5903e
1 parent 7cafa78
commit 1a5903e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/packages/main/src/Switch.hbs b/packages/main/src/Switch.hbs
@@ -4,6 +4,9 @@
 	aria-checked="{{checked}}"
 	aria-disabled="{{ariaDisabled}}"
 	aria-labelledby="{{_id}}-hiddenText"
+	@click="{{_onclick}}"
+	@keyup="{{_onkeyup}}"
+	@keydown="{{_onkeydown}}"
 	tabindex="{{tabIndex}}"
 	dir="{{rtl}}"
 >

diff --git a/packages/main/src/Switch.js b/packages/main/src/Switch.js
@@ -105,7 +105,6 @@ const metadata = {
 		 */
 		change: {},
 	},
-	_eventHandlersByConvention: true,
 };
 
 /**
@@ -159,11 +158,11 @@ class Switch extends UI5Element {
 		this.i18nBundle = getI18nBundle("@ui5/webcomponents");
 	}
 
-	onclick(event) {
+	_onclick(event) {
 		this.toggle();
 	}
 
-	onkeydown(event) {
+	_onkeydown(event) {
 		if (isSpace(event)) {
 			event.preventDefault();
 		}
@@ -173,7 +172,7 @@ class Switch extends UI5Element {
 		}
 	}
 
-	onkeyup(event) {
+	_onkeyup(event) {
 		if (isSpace(event)) {
 			this.toggle();
 		}