Skip to content

Commit

Permalink
fix(ui5-dynamic-page-title): separator fixed (#9621)
Browse files Browse the repository at this point in the history
Co-authored-by: PetyaMarkovaBogdanova <[email protected]>
  • Loading branch information
PetyaMarkovaBogdanova and PetyaMarkovaBogdanova authored Aug 2, 2024
1 parent 3eecdf8 commit 5240c0b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
4 changes: 3 additions & 1 deletion packages/fiori/src/DynamicPageTitle.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@
style="{{styles.actions}}">
<slot name="actionsBar"></slot>
{{#unless mobileNavigationActions}}
<div class="ui5-dynamic-page-title--actions-separator"></div>
{{#if _needsSeparator}}
<div class="ui5-dynamic-page-title--actions-separator"></div>
{{/if}}
<slot name="navigationBar"></slot>
{{/unless}}
</div>
Expand Down
4 changes: 4 additions & 0 deletions packages/fiori/src/DynamicPageTitle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,10 @@ class DynamicPageTitle extends UI5Element {
}
}

get _needsSeparator() {
return (this.navigationBar.length && this.actionsBar.length);
}

prepareLayoutActions() {
// all navigation/layout actions should have the NeverOverflow behavior
const navigationBar = this.querySelector<Toolbar>("[ui5-toolbar][slot='navigationBar']");
Expand Down

0 comments on commit 5240c0b

Please sign in to comment.