Skip to content

Commit

Permalink
fix(ui5-information): fix component visual (#1498)
Browse files Browse the repository at this point in the history
- fix type="Information" appearance, by setting the correct varialbes, previously the "neutral" semantic variables has been used
- fix the icons colors in all types, they used to remain grey (their default color), instead of being in the respective semantic color according to the component type

FIXES: #1496
  • Loading branch information
ilhan007 committed Apr 22, 2020
1 parent 1086101 commit 8a254d4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions packages/main/src/MessageStrip.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
aria-labelledby="{{_id}}">

{{#unless noIcon}}
<div class="ui5-messagestrip-icon">
<div class="ui5-messagestrip-icon-wrapper">
{{#if iconProvided}}
<slot name="icon"></slot>
{{else}}
<ui5-icon name="{{standardIconName}}"></ui5-icon>
<ui5-icon name="{{standardIconName}}" class="ui5-messagestrip-icon"></ui5-icon>
{{/if}}
</div>
{{/unless}}
Expand Down
8 changes: 4 additions & 4 deletions packages/main/src/themes/MessageStrip.css
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
position: relative;
}

.ui5-messagestrip-root .ui5-messagestrip-icon {
.ui5-messagestrip-root .ui5-messagestrip-icon-wrapper {
position: absolute;
top: var(--_ui5_messagestrip_icon_top);
left: 0.75rem;
Expand All @@ -45,13 +45,13 @@
}

.ui5-messagestrip--info {
background-color: var(--sapNeutralBackground);
border-color: var(--sapNeutralColor);
background-color: var(--sapInformationBackground);
border-color: var(--sapInformationBorderColor);
color: var(--sapTextColor);
}

.ui5-messagestrip--info .ui5-messagestrip-icon {
color: var(--sapNeutralElementColor);
color: var(--sapInformativeElementColor);
}

.ui5-messagestrip--positive {
Expand Down

0 comments on commit 8a254d4

Please sign in to comment.