fix(framework): reliably re-render lists of DOM nodes (#1519)

SAP · Apr 28, 2020 · 9edb5de · 9edb5de
1 parent c26e8aa
commit 9edb5de
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/main/test/specs/ComboBox.spec.js b/packages/main/test/specs/ComboBox.spec.js
@@ -25,7 +25,6 @@ describe("General interaction", () => {
 		const input = combo.shadow$("#ui5-combobox-input");
 		const staticAreaItemClassName = browser.getStaticAreaItemClassName("#combo");
 		const popover = browser.$(`.${staticAreaItemClassName}`).shadow$("ui5-responsive-popover");
-		const listItems = popover.$("ui5-list").$$("ui5-li");
 
 		input.click();
 		input.keys("b");
@@ -40,6 +39,7 @@ describe("General interaction", () => {
 
 		assert.strictEqual(selection, "ahrain", "ahrain should be selected");
 		assert.strictEqual(combo.getProperty("value"), "Bulgaria", "Value should be Bulgaria");
+		const listItems = popover.$("ui5-list").$$("ui5-li");
 		assert.ok(listItems[0].getProperty("selected"), "List Item should be selected");
 
 		lazy.click();
@@ -169,4 +169,4 @@ describe("General interaction", () => {
 		listItems = popover.$("ui5-list").$$("ui5-li");
 		assert.strictEqual(listItems.length, 0, "Items should be 0");
 	});
-});
+});
diff --git a/packages/tools/lib/hbs2lit/src/litVisitor2.js b/packages/tools/lib/hbs2lit/src/litVisitor2.js
@@ -135,7 +135,7 @@ function visitEachBlock(block) {
 	var bParamAdded = false;
 	visitSubExpression.call(this, block);
 
-	this.blocks[this.currentKey()] += "${ repeat(" + normalizePath.call(this, block.params[0].original) + ", undefined, (item, index) => ";
+	this.blocks[this.currentKey()] += "${ repeat(" + normalizePath.call(this, block.params[0].original) + ", (item, index) => item._id || index, (item, index) => ";
 	this.paths.push(normalizePath.call(this, block.params[0].original));
 	this.blockPath = "item";