Skip to content

Commit

Permalink
fix(ui5-table): call resize handler on initial rendering
Browse files Browse the repository at this point in the history
FIXES: #568
  • Loading branch information
MapTo0 committed Jul 4, 2019
1 parent 5a0b7ad commit b5a9019
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 16 deletions.
13 changes: 2 additions & 11 deletions packages/base/src/delegate/ResizeHandler.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import UI5Element from "../UI5Element.js";
import NativeResize from "./NativeResize.js";
import CustomResize from "./CustomResize.js";

Expand Down Expand Up @@ -33,30 +32,22 @@ class ResizeHandler {
/**
* @static
* @public
* @param {*} ref Reference to a UI5 Web Component or DOM Element to be observed
* @param {*} ref Reference to an HTML Element to be observed
* @param {*} callback Callback to be executed
* @memberof ResizeHandler
*/
static register(ref, callback) {
if (ref instanceof UI5Element) {
ref = ref.getDomRef();
}

ResizeHandler.attachListener(ref, callback);
}


/**
* @static
* @public
* @param {*} ref Reference to UI5 Web Component or DOM Element to be unobserved
* @param {*} ref Reference to an HTML Element to be unobserved
* @memberof ResizeHandler
*/
static deregister(ref, callback) {
if (ref instanceof UI5Element) {
ref = ref.getDomRef();
}

ResizeHandler.detachListener(ref, callback);
}
}
Expand Down
11 changes: 6 additions & 5 deletions packages/main/src/Table.js
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,11 @@ class Table extends UI5Element {
this._delegates.push(this._itemNavigation);

this.fnOnRowFocused = this.onRowFocused.bind(this);

this._handleResize = this.popinContent.bind(this);

// register the resize initially so it can be triggered when the element is rendered
ResizeHandler.register(this, this._handleResize);
}

onBeforeRendering() {
Expand All @@ -182,12 +187,8 @@ class Table extends UI5Element {
});
}

onEnterDOM() {
ResizeHandler.register(this.getDomRef(), this.popinContent.bind(this));
}

onExitDOM() {
ResizeHandler.deregister(this.getDomRef(), this.popinContent.bind(this));
ResizeHandler.deregister(this, this._handleResize);
}

onRowFocused(event) {
Expand Down

0 comments on commit b5a9019

Please sign in to comment.