Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProgressIndicator component #1392

Closed
vladitasev opened this issue Mar 30, 2020 · 0 comments · Fixed by #1887
Closed

ProgressIndicator component #1392

vladitasev opened this issue Mar 30, 2020 · 0 comments · Fixed by #1887
Assignees
@jdichev
Labels
feature request New Component TOPIC RD

Comments

@vladitasev
Copy link
Contributor

vladitasev commented Mar 30, 2020 •
edited
Loading

It would be good to have ProgressIndicator for 2 reasons:

  • As it makes sense in main as a bread-and-butter component
  • As it will be reused in UploadCollectionItem

API:

  • value: Int (0 to 100, how full it is)
  • valueState: to determine the color
  • hideValue: Boolean to not show the % value on the bar
  • noAnimation: Boolean to turn off the animation
  • disabled: Boolean to make it non-focusable and grey

No slots
No events

Set default height but let the user change it
Internal default witdth: 100%, take up the whole space the user gives
@vladitasev vladitasev added the RC8 label Apr 30, 2020
@ilhan007 ilhan007 mentioned this issue May 3, 2020
Closed
dobrinyonkov added a commit to dobrinyonkov/ui5-webcomponents that referenced this issue Jun 30, 2020
@dobrinyonkov
feat(ui5-progress-indicator): add accessibility
102242e 
Fixes: SAP#1392
dobrinyonkov added a commit to dobrinyonkov/ui5-webcomponents that referenced this issue Jun 30, 2020
@dobrinyonkov
feat(ui5-progress-indicator): add accessibility
df0144d 
Fixes: SAP#1392
dobrinyonkov added a commit to dobrinyonkov/ui5-webcomponents that referenced this issue Jun 30, 2020
@dobrinyonkov
feat(ui5-progress-indicator): add accessibility
1293039 
Fixes: SAP#1392
@nnaydenow nnaydenow mentioned this issue Jun 30, 2020
Merged
ilhan007 pushed a commit that referenced this issue Jul 5, 2020
@nnaydenow
feat(ui5-progress-indicator): initial implementation (#1887)
e8009c9 
Fixes: #1392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdichev jdichev

Labels
feature request New Component TOPIC RD
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ui5-progress-indicator): init implementation
4 participants
@jdichev @ilhan007 @vladitasev @dimovpetar