Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-messagestrip): fix component visual #1498

Merged
merged 1 commit into from
Apr 21, 2020
Merged

fix(ui5-messagestrip): fix component visual #1498

merged 1 commit into from
Apr 21, 2020

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Apr 20, 2020 •
edited
Loading

  • fix type="Information" appearance, by setting the correct variables, previously the "neutral" semantic variables has been used
  • fix the icons colours in all types, they used to remain grey (their default color), instead of being in the respective semantic color according to the component type

Before
Screenshot 2020-04-20 at 1 11 50 PM

After
Screenshot 2020-04-20 at 1 11 40 PM

FIXES: #1496

@ilhan007
fix(ui5-information): fix component visual
9e4333c 
- fix type="Information" appearance, by setting the correct varialbes, previously the "neutral" semantic variables has been used
- fix the icons colors in all types, they used to remain grey (their default color), instead of being in the respective semantic color according to the component type

FIXES: #1496
@ilhan007 ilhan007 changed the title fix(ui5-information): fix component visual fix(ui5-messagestrip): fix component visual Apr 20, 2020
@ilhan007 ilhan007 mentioned this pull request Apr 20, 2020
Closed
@ilhan007 ilhan007 merged commit 746f907 into master Apr 21, 2020
@ilhan007 ilhan007 deleted the fix-message-strip-information branch April 21, 2020 06:39
ilhan007 added a commit that referenced this pull request Apr 22, 2020
@ilhan007
fix(ui5-information): fix component visual (#1498)
8a254d4 
- fix type="Information" appearance, by setting the correct varialbes, previously the "neutral" semantic variables has been used
- fix the icons colors in all types, they used to remain grey (their default color), instead of being in the respective semantic color according to the component type

FIXES: #1496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev vladitasev approved these changes

Assignees
No one assigned
Labels
SAP SF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui5-messagestrip: maybe error for information type color
2 participants
@ilhan007 @vladitasev