Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5-popover:Hope to set the left/right minimum position of popover to 10px instead of 0 #1656

Closed
SherrySherry123 opened this issue May 20, 2020 · 1 comment · Fixed by #1690
Assignees
Labels

Comments

@SherrySherry123
Copy link

SherrySherry123 commented May 20, 2020

I am from Successfactors , and we are using ui5 webcomponent to build our own app.
Could you please help to implement the minimum position of popover? We hope its behavior to keep align with ui5.

Describe the bug
We hope that the left/right minimum position of popover is 10px instead of 0;

To reproduce
Steps to reproduce the behavior:

  1. Create one popover with placementType = Bottom;
  2. Open the popover and adjust the screen size;
  3. When there is no enough space to display the popover, the popover's left/right position will be set as 0. Which looks not that friendly from the UX perspective; So we hope there is a preserved space(10px);
    image

Expected behavior
We hope the left/right minimum position of popover is 10px;
I checked the UI5 component(sap.m.Popover) and attached screenshot.It looks like the preserved left/right position of sap.m.Popover is 10px, we hope to keep align with it.
https://github.com/SAP/openui5/blob/master/src/sap.m/src/sap/m/Popover.js
image

@SherrySherry123
Copy link
Author

Hi colleague,

Anyone can help to take a look at this issue? Looking forward to your response.

Regards,
Sherry

@ilhan007 ilhan007 self-assigned this May 27, 2020
ilhan007 added a commit that referenced this issue May 27, 2020
By design the popover should have a minimum 10 px offset from the window borders.

FIXES: #1656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants