Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<ui5-shellbar> search box overlaps other icons when the window is resized #2044

Closed
codefactor opened this issue Jul 31, 2020 · 2 comments · Fixed by #2155
Closed

<ui5-shellbar> search box overlaps other icons when the window is resized #2044

codefactor opened this issue Jul 31, 2020 · 2 comments · Fixed by #2155

Comments

@codefactor
Copy link
Contributor

Describe the bug
The search box in the shellbar is not properly positioned on the screen when the window is resized

To reproduce
Steps to reproduce the behavior:

  1. Go to https://sap.github.io/ui5-webcomponents/master/playground/components/ShellBar/
  2. Click the search button
  3. Resize the window horizontally
  4. Notice how the search box does not move position horizontally

Expected behavior
The search box should reposition itself according to the dimensions of the screen.

Screenshots
image

Context

  • UI5 Web Components version
  • OS/Platform: {...}
  • Browser (if relevant): {...}
  • Other information: {...}

Affected components (if known)

Log output / Any errors in the console

{...}
@ilhan007
Copy link
Member

We have that issue from our latest exloratory testing: #2000

But it is ok we can keep yours.

@jdichev
Copy link

jdichev commented Oct 30, 2020

Hello, this issue will be looked into with in one of the team's next sprints.
Internal reference: 4905

@ilhan007 ilhan007 modified the milestones: 1.0.0-rc.10, 1.0.0-rc.11 Nov 4, 2020
ilhan007 pushed a commit that referenced this issue Nov 26, 2020
Now, when there is not enough space for the search field it is expanded to full width within the ui5-shellbar
and the search filed does not overlap any other elements in the ui5-shellbar any more.

FIXES: #2044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants