Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-multi-input: [a11y] cannot trigger value-help-icon-press event via keyboard #2143

Closed
zhangliangyi opened this issue Aug 25, 2020 · 0 comments · Fixed by #2145
Closed

ui5-multi-input: [a11y] cannot trigger value-help-icon-press event via keyboard #2143

zhangliangyi opened this issue Aug 25, 2020 · 0 comments · Fixed by #2145
Assignees
@ilhan007
Labels
High Prio SAP SF SF_ACC
Milestone
0.23.3

Comments

@zhangliangyi
Copy link

zhangliangyi commented Aug 25, 2020 •
edited
Loading

Describe the bug
When create a ui5-multi-input, I could not trigger the value-help-icon-press event via keyboard. I tried to use the alt/option+arrow down just like the way in datepicker, but nothing happened.

Expected behavior
The value-help-icon-press event should be triggered after user press alt/option+arrow down which is same as https://sapui5.hana.ondemand.com/#/entity/sap.m.Input/sample/sap.m.sample.InputAssisted

Context

  • UI5 Web Components version: 0.23.1
  • OS/Platform: MacOS
  • Browser (if relevant): Chrome
  • Other information: N/A

Affected components (if known)
ui5-multi-input

Btw, is it necessary to add other aria attributes such as aria-haspopup="listbox" or provide an interface for component caller?

Thanks
@ilhan007 ilhan007 self-assigned this Aug 25, 2020
@ilhan007 ilhan007 added this to the 0.23.2 milestone Aug 25, 2020
ilhan007 added a commit that referenced this issue Aug 25, 2020
@ilhan007
feat(ui5-multi-inpuit): fire value-help-trigger with F4, Alt + ArrowU…
7910d22 
…p/Down

Fire the value-help-trigger when F4 or ALT/OPTION + ARROW_UP/ARROW_DOWN keyboard keys are used.

FIXES #2143

BREAKING_CHANGE value-help-icon-press is renamed to value-help-trigger
@ilhan007 ilhan007 mentioned this issue Aug 25, 2020
Merged
ilhan007 added a commit that referenced this issue Aug 26, 2020
@ilhan007
feat(ui5-multi-input): fire value-help-trigger with F4, ALT/OPTION + …
8c473c3 
…ARROW_UP/DOWN (#2145)

Fire the value-help-trigger when F4 or ALT/OPTION + ARROW_UP/ARROW_DOWN keyboard keys are used.

FIXES #2143

BREAKING CHANGE value-help-icon-press is renamed to value-help-trigger
@ilhan007 ilhan007 modified the milestones: 0.23.2, 0.23.3 Sep 15, 2020
ilhan007 added a commit that referenced this issue Sep 15, 2020
@ilhan007
feat(ui5-multi-input): fire value-help-trigger with F4, ALT/OPTION + …
045afc2 
…ARROW_UP/DOWN (#2145)

Fire the value-help-trigger when F4 or ALT/OPTION + ARROW_UP/ARROW_DOWN keyboard keys are used.

FIXES #2143

BREAKING CHANGE value-help-icon-press is renamed to value-help-trigger
ilhan007 added a commit that referenced this issue Oct 17, 2020
@ilhan007
feat(ui5-multi-input): fire value-help-trigger with F4, ALT/OPTION + …
0e29574 
…ARROW_UP/DOWN (#2145)

Fire the value-help-trigger when F4 or ALT/OPTION + ARROW_UP/ARROW_DOWN keyboard keys are used.

FIXES #2143

BREAKING CHANGE value-help-icon-press is renamed to value-help-trigger
ilhan007 added a commit that referenced this issue Nov 11, 2020
@ilhan007
feat(ui5-multi-input): fire value-help-trigger with F4, ALT/OPTION + …
85b4497 
…ARROW_UP/DOWN (#2145)

Fire the value-help-trigger when F4 or ALT/OPTION + ARROW_UP/ARROW_DOWN keyboard keys are used.

FIXES #2143

BREAKING CHANGE value-help-icon-press is renamed to value-help-trigger
@zhangliangyi zhangliangyi mentioned this issue Mar 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilhan007 ilhan007

Labels
High Prio SAP SF SF_ACC
Projects
None yet
Milestone
0.23.3
3 participants
@zhangliangyi @ilhan007 @nikolay-kolarov