Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog footer hidden on dialog is taller than screen height on IE11 #2243

Closed
ee92 opened this issue Sep 24, 2020 · 0 comments · Fixed by #2429
Closed

Dialog footer hidden on dialog is taller than screen height on IE11 #2243

ee92 opened this issue Sep 24, 2020 · 0 comments · Fixed by #2429
Assignees
@georgimkv
Labels
High Prio SAP SF TOPIC RD
Milestone
0.27.0

Comments

@ee92
Copy link

ee92 commented Sep 24, 2020

Describe the bug
When a dialog is taller than the screen height on IE11, the bottom of the dialog is hidden with no way to scroll it into view.

To reproduce
Steps to reproduce the behavior:

  1. Using IE11, go to https://sap.github.io/ui5-webcomponents/playground/components/Dialog/
  2. open the dialog
  3. resize the window to make the screen height shorter than the dialog.
  4. notice the bottom of the dialog becomes hidden.

Expected behavior
The behavior should be the same is on other browsers. The body of the dialog should shrink and become scrollable.

Screenshots
If applicable, add screenshots to help explain your problem.
Screen Shot 2020-09-21 at 4 05 06 PM

Context

  • UI5 Web Components version 0.23.1
  • Browser: IE11

Affected components
ui5-dialog
@ilhan007 ilhan007 added this to the 0.23.4 milestone Sep 24, 2020
@ilhan007 ilhan007 modified the milestones: 0.23.4, 0.23.5 Oct 6, 2020
@ilhan007 ilhan007 modified the milestones: 0.23.5, 0.23.6, 0.23.7 Oct 8, 2020
@georgimkv georgimkv self-assigned this Oct 27, 2020
@georgimkv georgimkv mentioned this issue Oct 30, 2020
Merged
ilhan007 pushed a commit that referenced this issue Nov 4, 2020
@georgimkv
fix(ui5-dialog): no longer gets clipped in short screen height in IE (#…
03c8447 
…2429)

Fixes: #2243
ilhan007 pushed a commit that referenced this issue Nov 11, 2020
@georgimkv @ilhan007
fix(ui5-dialog): no longer gets clipped in short screen height in IE (#…
f1c49e1 
…2429)

Fixes: #2243
@ilhan007 ilhan007 modified the milestones: 0.23.7, 0.23.8 Nov 16, 2020
ilhan007 pushed a commit that referenced this issue Nov 17, 2020
@georgimkv @ilhan007
fix(ui5-dialog): no longer gets clipped in short screen height in IE (#…
24a7351 
…2429)

Fixes: #2243
ilhan007 pushed a commit that referenced this issue Nov 19, 2020
@georgimkv @ilhan007
fix(ui5-dialog): no longer gets clipped in short screen height in IE (#…
7269d36 
…2429)

Fixes: #2243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgimkv georgimkv

Labels
High Prio SAP SF TOPIC RD
Projects
None yet
Milestone
0.27.0
Development

Successfully merging a pull request may close this issue.

fix(ui5-dialog): no longer gets clipped in short screen height in IE
3 participants
@ilhan007 @georgimkv @ee92