Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][SF][ui5-list] load-more event does not work, if I only set max-height to ui5 list #2882

Closed
sfsf-xweb-sh opened this issue Mar 1, 2021 · 3 comments · Fixed by #2950
Closed

[BUG][SF][ui5-list] load-more event does not work, if I only set max-height to ui5 list #2882

sfsf-xweb-sh opened this issue Mar 1, 2021 · 3 comments · Fixed by #2950
Assignees
@ilhan007
Labels
High Prio SAP SF

Comments

@sfsf-xweb-sh
Copy link

sfsf-xweb-sh commented Mar 1, 2021 •
edited
Loading

Dear colleagues,
I am from SuccessFactors Web Experience Shanghai team. My name is hubery and this account is our team account

Bug Description
Version: 0.29.4
If I only set max-height to ui5 list, load-more event does not work. ( I have already set infinite-scroll attribute to io5-list )
Screen Shot 2021-03-01 at 10 43 11 AM

Expected
If only max-height attribute is set to ui5-list, the load-more event can still work according to the actual height of ui5-list itself
@sfsf-xweb-sh sfsf-xweb-sh changed the title [BUG][ui5-list] load-more event does not work, if I only set max-height to ui5 list [BUG][ui5-list][SF] load-more event does not work, if I only set max-height to ui5 list Mar 1, 2021
@sfsf-xweb-sh sfsf-xweb-sh changed the title [BUG][ui5-list][SF] load-more event does not work, if I only set max-height to ui5 list [BUG][SF][ui5-list] load-more event does not work, if I only set max-height to ui5 list Mar 1, 2021
@ilhan007 ilhan007 added the SAP SF label Mar 1, 2021
@ilhan007
Copy link
Member

ilhan007 commented Mar 1, 2021

Hello @sfsf-xweb-sh is it possible to use an absolute height for the time being.
Actually this behaviour is known to us, we implemented it this way. The overflow behavior, and the load-more functionality depends on setting height to the List. Changing this would require bigger refactoring.

When do you need the fix at the latest?

@ilhan007 ilhan007 self-assigned this Mar 1, 2021
@sfsf-xweb-sh
Copy link
Author

Hi @ilhan007

Thanks for your reply and solution.
But our UX spec need us set max-height to ui5-list to finish our feature.

Best Regards

@ilhan007 ilhan007 assigned ilhan007 and unassigned ilhan007 Mar 12, 2021
@ilhan007 ilhan007 mentioned this issue Mar 16, 2021
Merged
ilhan007 added a commit that referenced this issue Mar 17, 2021
@ilhan007
feat(ui5-list): introduce "growing" property (#2950)
6fbbb21 
Similar to the ui5-table, now the ui5-list provides growing property with 3 available options:
Button, Scroll, None. 
As a side effect, it allows developers to set "max-height, overflow: auto" and the "load-more" still working as expected, fixing the referenced SF request #2882. Previously not possible as the List used to listen for the "scroll" of its internal container, which could not be influenced by these external styles.

FIXES: #2882

BREAKING_CHANGES: The "infiniteScroll" property has been removed, use growing="Scroll" instead.
ilhan007 added a commit that referenced this issue Mar 17, 2021
@ilhan007
feat(ui5-list): introduce "growing" property (#2950)
d0d684e 
Similar to the ui5-table, now the ui5-list provides growing property with 3 available options:
Button, Scroll, None.
As a side effect, it allows developers to set "max-height, overflow: auto" and the "load-more" still working as expected, fixing the referenced SF request #2882. Previously not possible as the List used to listen for the "scroll" of its internal container, which could not be influenced by these external styles.

FIXES: #2882

BREAKING_CHANGES: The "infiniteScroll" property has been removed, use growing="Scroll" instead.
@ilhan007
Copy link
Member

Please check this PR feat(ui5-list): introduce "growing" property #2950 it will be applied in the next release.

It introduces a breaking change, instead of infinite-scroll, you would need to set growing="Scroll" fro growing upon scroll, or growing="Button" to use "Load more button". Both ways you will get the load-more event as previous. But, now you would be able to set max-height as we refactored the List.

ilhan007 added a commit that referenced this issue Mar 18, 2021
@ilhan007
feat(ui5-list): introduce "growing" property (#2950)
7ac45d9 
Similar to the ui5-table, now the ui5-list provides growing property with 3 available options:
Button, Scroll, None. 
As a side effect, it allows developers to set "max-height, overflow: auto" and the "load-more" still working as expected, fixing the referenced SF request #2882. Previously not possible as the List used to listen for the "scroll" of its internal container, which could not be influenced by these external styles.

FIXES: #2882

BREAKING_CHANGES: The "infiniteScroll" property has been removed, use growing="Scroll" instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilhan007 ilhan007

Labels
High Prio SAP SF
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ui5-list): introduce "growing" property SAP/ui5-webcomponents
2 participants
@ilhan007 @sfsf-xweb-sh