Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeline throws an error #299

Closed
fifoosid opened this issue Apr 3, 2019 · 0 comments · Fixed by #321
Closed

Timeline throws an error #299

fifoosid opened this issue Apr 3, 2019 · 0 comments · Fixed by #321
Assignees
@MapTo0
Labels
bug This issue is a bug in the code good first issue A newcomer may work on this

Comments

@fifoosid
Copy link
Contributor

fifoosid commented Apr 3, 2019

Describe the bug
When a ui5-timeline-item is added to ui5-timeline, we can see the following error in the console:

DateFormat.js:147 Uncaught (in promise) TypeError: sap.ui.getWCCore is not a function
at Function.push../node_modules/@ui5/webcomponents-core/dist/sap/ui/core/format/DateFormat.js.DateFormat.createInstance (DateFormat.js:147)
at Function.push../node_modules/@ui5/webcomponents-core/dist/sap/ui/core/format/DateFormat.js.DateFormat.getDateTimeInstance (DateFormat.js:125)
at calculate (TimelineItemTemplateContext.js:15)

To reproduce
Steps to reproduce the behavior:

  1. Add ui5-timeline to your application
  2. Add ui5-timeline-item
  3. Check your console

Expected behavior
No error is thrown.

Affected components (if known)
ui5-timeline-item(ui5-timeline)
@fifoosid fifoosid added bug This issue is a bug in the code good first issue A newcomer may work on this labels Apr 3, 2019
@MapTo0 MapTo0 self-assigned this Apr 5, 2019
@MapTo0 MapTo0 mentioned this issue Apr 5, 2019
Closed
adrian-bobev added a commit that referenced this issue Apr 10, 2019
@adrian-bobev
refactor(ui5-timeline): change timestamp property to subtitleText
7fa936e 
Closes: #299

BREAKING CHANGE: 'timestamp' and 'timeFormat'  properties are removed.
Instead use subtitle-text property and directly format the text as
desired.
@adrian-bobev adrian-bobev mentioned this issue Apr 10, 2019
Merged
adrian-bobev added a commit that referenced this issue Apr 12, 2019
@adrian-bobev
refactor(ui5-timeline): change timestamp property to subtitleText (#321)
287548e 
Closes: #299

BREAKING CHANGE: 'timestamp' and 'timeFormat'  properties are removed.
Instead use subtitle-text property and directly format the text as
desired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MapTo0 MapTo0

Labels
bug This issue is a bug in the code good first issue A newcomer may work on this
Projects
None yet
Milestone
No milestone
2 participants
@MapTo0 @fifoosid