Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-shellbar, empty string value in attribute 'notification-count' should hide the badge #3121

Closed
maltenorstroem opened this issue Apr 9, 2021 · 1 comment · Fixed by #3123
Closed

ui5-shellbar, empty string value in attribute 'notification-count' should hide the badge #3121

maltenorstroem opened this issue Apr 9, 2021 · 1 comment · Fixed by #3123
Assignees
@ilhan007
Labels
bug This issue is a bug in the code Low Prio TOPIC P

Comments

@maltenorstroem
Copy link

If show-notifications and notification-count are used in the ui5-shellbar, the notification badge remains even though notification-count is empty.

To reproduce

  1. <ui5-shellbar id="shellbar" primary-title="Corporate Portal" secondary-title="secondary title" notification-count="99+" show-notifications>
  2. set notificaton-count to empty string
  3. badge still remains

Isolated example
https://sap.github.io/ui5-webcomponents/playground/components/ShellBar/

Expected behavior
If the attribute "notification-count" is empty, the counter badge should no longer be displayed.

Screenshot 2021-04-09 at 08 00 41

Context

  • UI5 Web Components version: master

Affected components
@ui5/webcomponents-fiori ui5-shellbar

Priority: Medium
@ilhan007 ilhan007 added TOPIC P Low Prio bug This issue is a bug in the code labels Apr 9, 2021
@ilhan007 ilhan007 mentioned this issue Apr 9, 2021
Merged
@ilhan007
Copy link
Member

ilhan007 commented Apr 9, 2021

Hi @maltenorstroem thanks for reporting, we address the issue with #3123

@ilhan007 ilhan007 self-assigned this Apr 9, 2021
ilhan007 added a commit that referenced this issue Apr 9, 2021
@ilhan007
fix(ui5-shellbar): hide notification bubble if empty str (#3123)
33fde82 
The notification bubble used to remain displayed when notification-count is an empty string.

Fixes: #3121
@petyabegovska petyabegovska moved this to Completed in Maintenance - Topic P Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilhan007 ilhan007

Labels
bug This issue is a bug in the code Low Prio TOPIC P
Projects
Maintenance - Topic P
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-shellbar): hide notification bubble if empty str SAP/ui5-webcomponents
2 participants
@maltenorstroem @ilhan007