Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-shellbar): hide notification bubble if empty str #3123

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Apr 9, 2021

The notification bubble used to remain displayed when notification-count is an empty string
Screenshot 2021-04-09 at 09 53 02

Fixes: #3121

@ilhan007 ilhan007 merged commit 33fde82 into master Apr 9, 2021
@ilhan007 ilhan007 deleted the fix-sb-notif-count branch April 9, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui5-shellbar, empty string value in attribute 'notification-count' should hide the badge
2 participants