Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResponsivePopover: in mobile view the close button is missing a11y annotation and is left aligned if no header/headerText is set #3173

Closed
Lukas742 opened this issue Apr 21, 2021 · 2 comments · Fixed by #3176
Labels
bug This issue is a bug in the code Medium Prio TOPIC RD

Comments

@Lukas742
Copy link
Collaborator

Lukas742 commented Apr 21, 2021

Describe the bug
The close button of the ResponsivePopover in mobile view is positioned to the left if no header or headerText is set. Also the button is ignored by screen-readers, so it's hard for visually impaired people to exit the dialog.

To reproduce
Steps to reproduce the behavior:

  1. Go to codesandbox
  2. Use the dev tools to simulate a mobile device
  3. Open popover and see that the close button is displayed on the left side
  4. Focus the close button with a screen reader enabled --> only "Content" is read out - no information about the close button is given

Isolated example
https://codesandbox.io/s/ui5-webcomponents-forked-bwdmg?from-embed=&file=/index.html

Expected behavior
The close button should be read out by screen readers and it should always be positioned to the right.

Screenshots
image

Context

Edit: I just noticed that if a header (header or headerText) is used, the close button is not moved to the header section but is displayed below:

image

The screenshot was taken from the ResponsivePopover playground

@alexandar-mitsev alexandar-mitsev self-assigned this Apr 21, 2021
@alexandar-mitsev alexandar-mitsev added TOPIC RD bug This issue is a bug in the code Medium Prio labels Apr 21, 2021
@alexandar-mitsev alexandar-mitsev removed Medium Prio TOPIC RD bug This issue is a bug in the code labels Apr 21, 2021
@alexandar-mitsev
Copy link
Contributor

Hello @Lukas742 ,

When testing with JAWS 2019 or NVDA screen readers the close button is read out correctly: "Decline button. To activate press space bar.". It contains the correct aria-label attribute. So it seems the problem is related to the particular screen reader you are using - we won't be able to assist further about it.

I will forward the ticket for processing about the position of the icon.

Regards,
Alexandar Mitsev

@alexandar-mitsev
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-rd ,

Please take a look at the reported problem with the position of the close button in the responsive popover on mobile.
The second problem about the screen reader is already answered.

Regards,
Alexandar Mitsev

@alexandar-mitsev alexandar-mitsev added bug This issue is a bug in the code TOPIC RD Medium Prio labels Apr 21, 2021
@alexandar-mitsev alexandar-mitsev removed their assignment Apr 21, 2021
ilhan007 added a commit that referenced this issue Apr 22, 2021
We use lit-html classMaps to render classes out of objects , but it works with this getter "get classes()" not with any getters.

FIXES: #3173
ilhan007 added a commit that referenced this issue Jul 26, 2021
We use lit-html classMaps to render classes out of objects , but it works with this getter "get classes()" not with any getters.

FIXES: #3173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio TOPIC RD
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

2 participants