Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-label): fix required label in safari #3182

Merged
merged 6 commits into from
May 13, 2021
Merged

fix(ui5-label): fix required label in safari #3182

merged 6 commits into from
May 13, 2021

Conversation

fifoosid
Copy link
Contributor

Fixes #3164

@fifoosid fifoosid changed the title Label safari fix(ui5-label): fix required label in safari Apr 23, 2021
ilhan007
ilhan007 requested changes Apr 28, 2021
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes requested

@fifoosid fifoosid requested a review from ilhan007 April 29, 2021 08:12
ilhan007
ilhan007 previously approved these changes Apr 29, 2021
View reviewed changes
@fifoosid fifoosid merged commit 921ac5a into master May 13, 2021
@fifoosid fifoosid deleted the label-safari branch May 13, 2021 07:26
ilhan007 pushed a commit that referenced this pull request Jun 1, 2021
@fifoosid @ilhan007
fix(ui5-label): fix required label in safari (#3182)
eb03fe5
ilhan007 pushed a commit that referenced this pull request Jun 1, 2021
@fifoosid @ilhan007
fix(ui5-label): fix required label in safari (#3182)
2d857db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

Assignees
No one assigned
Labels
for review SAP SF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui5-label: ui5-label with required symbol is truncated in Safari
2 participants
@fifoosid @ilhan007