Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SF] [ValueState] - The vertical padding of value state is not consistent #3611

Closed
1 of 4 tasks
2bno1 opened this issue Aug 7, 2021 · 3 comments · Fixed by #3833
Closed
1 of 4 tasks

[SF] [ValueState] - The vertical padding of value state is not consistent #3611

2bno1 opened this issue Aug 7, 2021 · 3 comments · Fixed by #3833
Assignees
@ndeshev
Labels
bug This issue is a bug in the code SAP SF TOPIC P TOPIC RL Very High Prio

Comments

@2bno1
Copy link

2bno1 commented Aug 7, 2021

Bug DescriptionThe vertical padding of the value state of ui5-input with suggestion item is 16px. It is not consistent to ui5-select which is 9px.

Expected Behavior

The vertical padding of the value state of ui5-input with suggestion item is consistent to ui5-select which is 0.5625rem (or 9px)

Steps to Reproduce

  1. https://codesandbox.io/s/ui5-webcomponents-forked-on84c?file=/index.html
  2. Check the vertical padding of the value state of both the ui5-input and ui5-select.

Isolated Example

https://codesandbox.io/s/ui5-webcomponents-forked-on84c?file=/index.html

Context

  • UI5 Web Components version: 0.31.14
  • OS/Platform: macOS
  • Browser: Chrome
  • Affected component: ui5-input

Log Output / Stack Trace / Screenshots

image
image

Priority

  • Low

  • Medium

  • High

  • Very High

  • Organization: SuccessFactors
@GerganaKremenska GerganaKremenska self-assigned this Aug 9, 2021
@GerganaKremenska GerganaKremenska added bug This issue is a bug in the code TOPIC P labels Aug 9, 2021
@GerganaKremenska
Copy link
Member

Hello @ui5-webcomponents-topic-p,
I am forwarding this issue to you, because there is a diffrence in styling of the value state of Input and Select component.
Check the design and sync the implementation.

@GerganaKremenska GerganaKremenska removed their assignment Aug 9, 2021
@nnaydenow nnaydenow self-assigned this Aug 13, 2021
@nnaydenow nnaydenow mentioned this issue Aug 13, 2021
Merged
@nnaydenow
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-rl ,

Both components are not align to the spec. From our side ui5-select is fixed with #3655 which is under review.

I'm sending this issue to you to align ui5-input.

Regards,
Nayden

@ndeshev ndeshev assigned ndeshev and unassigned nnaydenow Aug 16, 2021
ilhan007 pushed a commit that referenced this issue Aug 16, 2021
@nnaydenow
fix(ui5-select): align value state to visual specification (#3655)
cce6505 
By visual specification the value state message should have 32px height when it is on a single line.

#3611
@ndeshev ndeshev mentioned this issue Sep 4, 2021
Merged
ilhan007 pushed a commit that referenced this issue Sep 16, 2021
@ndeshev
fix(ui5-input): adjust value state paddings according to specificatio…
4c8ff0c 
…ns (#3833)

The padding of the value state message popup and header are fixed to reflect the Fiori specifications.

Fixes: #3611
Closes: #3611
ilhan007 pushed a commit that referenced this issue Sep 16, 2021
@ndeshev @ilhan007
fix(ui5-input): adjust value state paddings according to specificatio…
48bd6fe 
…ns (#3833)

The padding of the value state message popup and header are fixed to reflect the Fiori specifications.

Fixes: #3611
Closes: #3611
@ilhan007
Copy link
Member

fixed with 0.31.18

@petyabegovska petyabegovska moved this to Completed in Maintenance - Topic P Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndeshev ndeshev

Labels
bug This issue is a bug in the code SAP SF TOPIC P TOPIC RL Very High Prio
Projects
Maintenance - Topic P
Status: Completed
Maintenance - Topic RL
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-input): adjust value state paddings according to specifications ndeshev/ui5-webcomponents
5 participants
@ndeshev @2bno1 @ilhan007 @GerganaKremenska @nnaydenow