Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-dialog: issues found from exploratory testing #3620

Closed
1 of 4 tasks
georgimkv opened this issue Aug 10, 2021 · 0 comments · Fixed by #3893
Closed
1 of 4 tasks

ui5-dialog: issues found from exploratory testing #3620

georgimkv opened this issue Aug 10, 2021 · 0 comments · Fixed by #3893
Assignees
@kskondov
Labels
1.0 Release Testing bug This issue is a bug in the code Medium Prio TOPIC RD

Comments

@georgimkv
Copy link
Contributor

Bug Description

When a dialog gets created with but not placed in the DOM, there is an warning/violation message in the console.

Steps to Reproduce

  1. Go to https://sap.github.io/ui5-webcomponents/master/playground/main/pages/Dialog/
  2. Click last button "Open dialog which is created dynamically"
  3. Warning in console.

Isolated Example

If possible, please provide an isolated example by forking CodeSandbox.

Context

  • UI5 Web Components version: master

Log Output / Stack Trace / Screenshots

image

The full details can be seen if running on the example on localhost.

Priority

  • Low
  • Medium
  • High
  • Very High
@georgimkv georgimkv added bug This issue is a bug in the code Medium Prio TOPIC RD labels Aug 10, 2021
@Lukas742 Lukas742 mentioned this issue Aug 24, 2021
Closed
@kskondov kskondov self-assigned this Sep 8, 2021
kskondov added a commit that referenced this issue Sep 10, 2021
@kskondov
fix(ui5-dialog): exploratory testing issues
770dc81 
There is no ResizeHandler warning when a dialog is created dynamically

Fixes: #3620
@kskondov kskondov mentioned this issue Sep 10, 2021
Merged
ilhan007 pushed a commit that referenced this issue Sep 10, 2021
@kskondov
fix(ui5-dialog): fix console warning from exploratory testing (#3893)
c648714 
There is no ResizeHandler warning when a dialog is created dynamically

Fixes: #3620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kskondov kskondov

Labels
1.0 Release Testing bug This issue is a bug in the code Medium Prio TOPIC RD
Projects
Maintenance - Topic RD
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-dialog): fix console warning from exploratory testing SAP/ui5-webcomponents
3 participants
@kskondov @ilhan007 @georgimkv