Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SF][UI5-link][Safari]-No underline style when adding "text-decoration: underline" for ui5-link component #3837

Closed
herlinsong opened this issue Sep 6, 2021 · 2 comments · Fixed by #3911
Closed

[SF][UI5-link][Safari]-No underline style when adding "text-decoration: underline" for ui5-link component #3837

herlinsong opened this issue Sep 6, 2021 · 2 comments · Fixed by #3911
Assignees
@a-z-ivanov
Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC B

Comments

@herlinsong
Copy link

Describe the bug
This issue only happened in Safari. I want to add link hover style "text-decoration: underline" for ui5-link when hovering on it's parent's node, but the underline of the ui5-link is not shown in Safari.
The underline of the ui5-link is shown in Chrome/Firefox/Edge/IE.

Defect demo
https://uvgbg.csb.app/

UI5 WC Demo
https://sap.github.io/ui5-webcomponents/playground/components/Link/

To Reproduce

  1. Define "text-decoration: underline" for "linkHover" className
  2. When hovering on the parent node, will add "linkHover" className for ui5-link

Expected behavior
The link has underline style
image

UI5 Web Components Information
@ui5/webcomponents version: Current Version
Operating System: macOS Big Sur
Browser: Safari Version 14.1.1 (16611.2.7.1.4)
@georgimkv georgimkv self-assigned this Sep 7, 2021
@georgimkv georgimkv added bug This issue is a bug in the code Medium Prio TOPIC B labels Sep 7, 2021
@georgimkv
Copy link
Contributor

Hi @SAP/ui5-webcomponents-topic-b
The Link component has a bug in Safari where specifying text-decoration: underline doesn't work.

Regards,
Georgi

@georgimkv georgimkv removed their assignment Sep 9, 2021
@a-z-ivanov a-z-ivanov self-assigned this Sep 13, 2021
a-z-ivanov pushed a commit that referenced this issue Sep 13, 2021
fix(ui5-link): exposes the anchor element for styling
37e7ec0 
Fix #3837
@a-z-ivanov a-z-ivanov mentioned this issue Sep 13, 2021
Merged
2 tasks
ilhan007 pushed a commit that referenced this issue Sep 14, 2021
fix(ui5-link): the anchor element inherits its text-decoration (#3911)
bb8629c 
Fixes: #3837
Closes: #3837
ilhan007 pushed a commit that referenced this issue Sep 16, 2021
@ilhan007
fix(ui5-link): the anchor element inherits its text-decoration (#3911)
276b142 
Fixes: #3837
Closes: #3837
@ilhan007
Copy link
Member

Fixed with 0.31.18

@petyabegovska petyabegovska moved this to Completed in Maintenance - Topic B Jun 21, 2024
@danieldegroot2 danieldegroot2 mentioned this issue Jul 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-z-ivanov a-z-ivanov

Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC B
Projects
Maintenance - Topic B
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-link): the anchor element inherits its text-decoration SAP/ui5-webcomponents
4 participants
@a-z-ivanov @ilhan007 @georgimkv @herlinsong