Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5-busy-indicator crashes in ui5-dialog during initial render #4108

Closed
1 of 4 tasks
MarcusNotheis opened this issue Oct 12, 2021 · 1 comment · Fixed by #4321
Closed
1 of 4 tasks

ui5-busy-indicator crashes in ui5-dialog during initial render #4108

MarcusNotheis opened this issue Oct 12, 2021 · 1 comment · Fixed by #4321
Assignees
Labels
bug This issue is a bug in the code Medium Prio TOPIC RD

Comments

@MarcusNotheis
Copy link
Collaborator

Bug Description

When rendering an ui5-dialog for the first time and immediately opening it with an active ui5-busy-indicator inside, the site crashes with a JS runtime error:

TypeError: Cannot read properties of null (reading 'focus')

Expected Behavior

Busy Indicator should be active and no error should be thrown

Steps to Reproduce

  1. Open https://codesandbox.io/s/table-dialog-busy-ntti7?file=/src/App.js
  2. Click "Show Dialog" button
  3. see the error

Isolated Example

https://codesandbox.io/s/table-dialog-busy-ntti7?file=/src/App.js

Context

  • UI5 Web Components version: 1.0.0-rc.15 (and latest snapshots as well)
  • OS/Platform: macOS
  • Browser: Chrome
  • Affected component: ui5-busy-indicator

Log Output / Stack Trace / Screenshots

TypeError: Cannot read properties of null (reading 'focus')
HTMLElement._redirectFocus
node_modules/@ui5/webcomponents/dist/BusyIndicator.js:265
  262 | 		}
  263 | 
  264 | 		event.preventDefault();
> 265 | 		this.shadowRoot.querySelector(".ui5-busy-indicator-busy-area").focus();
  266 | 	}
  267 | }
  268 | 

Priority

  • Low
  • Medium
  • High
  • Very High

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

  • Breaks entire application or system - High or Very High
  • Accessibility issue - Medium or High
  • Functional issue - Medium or High
  • Visual issue - Low or Medium

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

  • Organization: UI5 Web Components for React / SAP Value Experience
@Shtilianova Shtilianova added the bug This issue is a bug in the code label Oct 13, 2021
@Shtilianova
Copy link

Hello @SAP/ui5-webcomponents-topic-rd,
This is a reproducible issue with dialog with busy indicator.
Kind regards, Diana

@dimovpetar dimovpetar self-assigned this Nov 11, 2021
dimovpetar added a commit that referenced this issue Nov 11, 2021
- Don't render focusable elements until the delay has passed
- Don't reduce the opacity and prevent actions of the slotted elements until the delay has passed

Fixes: #4108
ilhan007 pushed a commit that referenced this issue Nov 25, 2021
Don't render focusable elements until the delay has passed
Don't reduce the opacity and prevent actions of the slotted elements until the delay has passed
Fixes: #4108
ndeshev pushed a commit to ndeshev/ui5-webcomponents that referenced this issue Dec 13, 2021
Don't render focusable elements until the delay has passed
Don't reduce the opacity and prevent actions of the slotted elements until the delay has passed
Fixes: SAP#4108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio TOPIC RD
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants