feat(ui5-list): preventable item-click event #4448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this change we introduce the preventable behaviour of the item-click event in the List component.
4 tasks
2 tasks
|
Keep in mind: #1618 . Let's investigate it. |
additionally the press and click events are now fired before selection
|
Looks good to me. Currently ui5-item-press is used only internally and it shouldn't be part of the prevention. |
nnaydenow
approved these changes
Dec 8, 2021
|
Could you also add Fixes: link of the issue in the commit message. It can be edited in the Github UI, but later when you press the Squash and merge button, you need to fix it and make sure |
|
Hi @ilhan007 , Sorry but I saw your comment after I merged it. It seems like the issue has closed automatically since it's linked with the pull request. |
eshpak
pushed a commit
to eshpak/ui5-webcomponents
that referenced
this pull request
Jan 9, 2022
* feat(ui5-list): preventable item-click event In this change we introduce the preventable behaviour of the item-click event in the List component. * fixed name of test * fixed failing tests additionally the press and click events are now fired before selection
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this change we introduce the preventable behaviour of the item-click
event in the List component.
Thank you for your contribution! 👏
To get it merged faster, kindly review the checklist below:
Pull Request Checklist