refactor(ui5-list): removed ui5-item-press event #4471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @SAP/ui5-webcomponents-topic-rd and @SAP/ui5-webcomponents-topic-rl, Could you please check if everything works okey with the components that you are responsible for? Regards, |
nnaydenow
requested review from
ilhan007,
plamenivanov91,
fifoosid and
kineticjs
georgimkv
suggested changes
Dec 13, 2021
georgimkv
previously approved these changes
Dec 13, 2021
|
LGTM from @SAP/ui5-webcomponents-topic-rd |
kineticjs
previously approved these changes
Dec 14, 2021
georgimkv
suggested changes
Dec 15, 2021
|
lgtm |
MapTo0
approved these changes
Dec 15, 2021
georgimkv
approved these changes
Dec 15, 2021
niyap
approved these changes
Dec 15, 2021
plamenivanov91
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed usage of undocumented ui5-item-press event. In addition controls which were using are refactored to use ui5-selection-change event of the ui5-list. With #4448 ui5-item-click event is fired before ui5-selection-change in order to cancel the click / selection if needed and the event doesn't provide information if the clicked item is selected.