Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-card: card header issue in RTL #4451

Closed
1 of 4 tasks
LidiyaGeorgieva opened this issue Dec 8, 2021 · 2 comments · Fixed by #4536
Closed
1 of 4 tasks

ui5-card: card header issue in RTL #4451

LidiyaGeorgieva opened this issue Dec 8, 2021 · 2 comments · Fixed by #4536
Assignees
@fifoosid
Labels
bug This issue is a bug in the code Medium Prio TOPIC Core

Comments

@LidiyaGeorgieva
Copy link
Contributor

Bug Description

Header elements are not correctly positioned inside the header.
image

image

Steps to Reproduce

  1. Go to 'Playground'
  2. switch to phone
  3. switch to RTL

Priority

  • Low
  • Medium
  • High
  • Very High
@LidiyaGeorgieva LidiyaGeorgieva added bug This issue is a bug in the code TOPIC RD Medium Prio labels Dec 8, 2021
@LidiyaGeorgieva LidiyaGeorgieva self-assigned this Dec 8, 2021
@LidiyaGeorgieva
Copy link
Contributor Author

The "div" element with class "ui5-card-header" in the Playground doesn't receive dir="rtl".
In the separate test samples this is not reproducible.
If the "dir" is in place there is no issue:
image

Issue is possibly related to #3624

@georgimkv
Copy link
Contributor

Hi @SAP/ui5-webcomponents-topic-core
This issue looks similar to #3624.
The Playground app has some odd behaviour when switching to RTL mode.

Regards,
Georgi

@fifoosid fifoosid self-assigned this Dec 30, 2021
@fifoosid fifoosid mentioned this issue Dec 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fifoosid fifoosid

Labels
bug This issue is a bug in the code Medium Prio TOPIC Core
Projects
Maintenance - Topic Core
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-card-header): fix rtl support SAP/ui5-webcomponents
3 participants
@LidiyaGeorgieva @fifoosid @georgimkv