Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground app: issue with styles when switching to RTL #3624

Closed
1 of 4 tasks
georgimkv opened this issue Aug 10, 2021 · 6 comments
Closed
1 of 4 tasks

Playground app: issue with styles when switching to RTL #3624

georgimkv opened this issue Aug 10, 2021 · 6 comments
Assignees
Labels

Comments

@georgimkv
Copy link
Contributor

Bug Description

In RTL, tabs with icons have the text too close to the icon.

Steps to Reproduce

  1. Go to https://sap.github.io/ui5-webcomponents/master/playground/components/TabContainer/?sap-ui-theme=sap_fiori_3&isrtl=true

Context

  • UI5 Web Components version: master

Log Output / Stack Trace / Screenshots

image

Priority

  • Low
  • Medium
  • High
  • Very High
@georgimkv georgimkv added bug This issue is a bug in the code Medium Prio TOPIC RD labels Aug 10, 2021
@kskondov kskondov self-assigned this Aug 19, 2021
@georgimkv
Copy link
Contributor Author

Hi @SAP/ui5-webcomponents-topic-core

I believe this is an issue with the Playground app.
Switching to RTL mode from "Language and Theme settings" side menu doesn't seem to reset the styles correctly, rendering the results in the screenshot above.

This doesn't happen on https://sap.github.io/ui5-webcomponents/master/playground/main/pages/TabContainer/?sap-ui-language=he which works fine.

Regards,
Georgi

@ilhan007
Copy link
Member

Hello @gmkv seems to work now in the master playground

Screenshot 2021-11-19 at 22 48 38

ed

@ilhan007 ilhan007 self-assigned this Nov 19, 2021
@georgimkv
Copy link
Contributor Author

It's still reproducible. Load https://sap.github.io/ui5-webcomponents/master/playground/components/TabContainer/, then change the text direction to RTL from the settings menu on the Playground app.

@georgimkv georgimkv reopened this Nov 22, 2021
@georgimkv
Copy link
Contributor Author

If it helps tracking down the bug, clicking on the tabs will "fix" the issue.

@ilhan007
Copy link
Member

Thanks, @gmkv now I could reproduce it!

@georgimkv georgimkv changed the title ui5-tabcontainer: issue found from exploratory testing Playground app: issue with styles when switching to RTL Dec 10, 2021
@fifoosid fifoosid assigned fifoosid and unassigned ilhan007 Dec 30, 2021
@fifoosid
Copy link
Contributor

This issue is resolved in the master branch. The issue was indeed in the way the Playground was setting RTL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

No branches or pull requests

4 participants