Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-breadcrumbs: incorrect displaying of items #4565

Closed
nnaydenow opened this issue Jan 12, 2022 · 0 comments · Fixed by #4578
Closed

ui5-breadcrumbs: incorrect displaying of items #4565

nnaydenow opened this issue Jan 12, 2022 · 0 comments · Fixed by #4578
Assignees
@kineticjs
Labels
bug This issue is a bug in the code Medium Prio TOPIC P

Comments

@nnaydenow
Copy link
Contributor

nnaydenow commented Jan 12, 2022 •
edited
Loading

Bug Description

When ui5-breadcrumbs has only one ui5-breadcrumbs-item it is not displayed.

Expected Behavior

If only one ui5-breadcrumbs-item is provided it should be displayed as:

  • text if design is set to Standard
  • link with separator after it if the design is set to NoCurrentPage

Steps to Reproduce

  1. Go to Playground sample
  2. Leave only 1 ui5-breadcrumbs-item in random ui5-breadcrumbs at the page.

Follow up: #4563
@nnaydenow nnaydenow added the bug This issue is a bug in the code label Jan 12, 2022
@nnaydenow nnaydenow mentioned this issue Jan 12, 2022
Merged
@kineticjs kineticjs self-assigned this Jan 13, 2022
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jan 13, 2022
@kineticjs
fix(ui5-breadcrumbs): correct missing label for single breadcrumb
5534eec 
Add the missing label of breadcrumbs with a single item.

Fixes SAP#4565
@kineticjs kineticjs mentioned this issue Jan 13, 2022
Merged
ilhan007 pushed a commit that referenced this issue Jan 17, 2022
@kineticjs
fix(ui5-breadcrumbs): correct missing label for single breadcrumb (#4578
42254d8 
)

Add the missing label of breadcrumbs with a single item.

Fixes #4565
@petyabegovska petyabegovska moved this to Completed in Maintenance - Topic P Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kineticjs kineticjs

Labels
bug This issue is a bug in the code Medium Prio TOPIC P
Projects
Maintenance - Topic P
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-breadcrumbs): correct missing label for single breadcrumb kineticjs/ui5-webcomponents
2 participants
@kineticjs @nnaydenow