Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt components with Popover responsive paddings #4869

Closed
ilhan007 opened this issue Mar 9, 2022 · 1 comment · Fixed by #4977 or #4985
Closed

Adapt components with Popover responsive paddings #4869

ilhan007 opened this issue Mar 9, 2022 · 1 comment · Fixed by #4977 or #4985
Assignees

Comments

@ilhan007
Copy link
Member

ilhan007 commented Mar 9, 2022

Description

Recently responsive paddings have been introduced to the Popover with the following change #4567 causing some wrong paddings mainly within the headers and footers of components internally using the Popover.
The components below received responsive paddings for the header, footer and the content. For some of them they are switched off (using parts in css files of every component). Review them and adjust the paddings in order to implement the target design.
Note: in openui5 for historical reasons responsive paddings are not set by default, in web components they are.

Expected actions

Check the affected components on Desktop and Mobile and fix paddings if necessary. If the listed components below are fine in terms of content, header, footer paddings - close the issue.

Affected components

  • ColorPalettePopover
  • File Uploader
  • DatePickerPopover
  • ViewSettingsDialog
  • TimePicker

Existing issues by users

Context

  • UI5 Web Components version: master

Contact person

Lidiya Georgieva

@ilhan007
Copy link
Member Author

ilhan007 commented Mar 9, 2022

FYI @SAP/ui5-webcomponents-topic-b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment