Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List: Images rendered differently in Chrome/Safari #4873

Closed
1 of 4 tasks
goodefroi opened this issue Mar 9, 2022 · 3 comments · Fixed by #4877
Closed
1 of 4 tasks

List: Images rendered differently in Chrome/Safari #4873

goodefroi opened this issue Mar 9, 2022 · 3 comments · Fixed by #4877
Assignees
Labels
bug This issue is a bug in the code TOPIC P

Comments

@goodefroi
Copy link

goodefroi commented Mar 9, 2022

Bug Description

Images within list items are rendered as a circle on Safari whilst rendered as a square with round corners on Chrome.

Expected Behavior

Both browsers render images in the same shape by default.

Steps to Reproduce

Open the documentation of the List component with both Chrome and Safari.

Context

  • UI5 Web Components version: 1.2.1
  • OS/Platform: macOS 12.2.1
  • Browser: Chrome 99/Safari 15.3
  • Affected component: ui5-list

Screenshots

Chrome 99:
image

Safari 15.3:
image

Priority

  • Low
  • Medium
  • High
  • Very High
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova self-assigned this Mar 9, 2022
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova added bug This issue is a bug in the code TOPIC P labels Mar 9, 2022
@PetyaMarkovaBogdanova
Copy link
Contributor

Hi colleagues,
ui5-avatar with shape "Square" is showed in circular shape in Safari.
Can you, please, check?

Kind regards,
Petya Markova.
(UI5 Dispatcher)

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova removed their assignment Mar 9, 2022
@ilhan007
Copy link
Member

ilhan007 commented Mar 9, 2022

The second selector takes precedence on Safari

/*  Avatar.css */
:host([shape=Square]),
:host([shape=Square]) ::slotted(*) {
  border-radius: .25rem;
}

::slotted(*) {
  border-radius: 50%;
}

@nnaydenow nnaydenow self-assigned this Mar 9, 2022
ilhan007 pushed a commit that referenced this issue Mar 10, 2022
Safari applies styles of last defined slot selector.

Fixes: #4873
ilhan007 pushed a commit that referenced this issue Mar 18, 2022
Safari applies styles of last defined slot selector.

Fixes: #4873
@wulinjie122
Copy link

wulinjie122 commented Jul 4, 2022

Hi @ilhan007,
Is there a property to set the shape of avatar within ui5 list item?
I want render a Circle avatar, but the image by default is Square .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code TOPIC P
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

5 participants