Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiComboBox - Adding customizable search function #799

Closed
Lukas742 opened this issue Sep 27, 2019 · 4 comments · Fixed by #2088
Closed

MultiComboBox - Adding customizable search function #799

Lukas742 opened this issue Sep 27, 2019 · 4 comments · Fixed by #2088

Comments

@Lukas742
Copy link
Collaborator

Describe the solution you'd like
Right now the MultiComboBox has a default search that implements the startsWith function.
It would be great to have an opportunity to add a custom search functions (e.g. contains, ignore case, etc.).

@vladitasev
Copy link
Contributor

Check if it makes sense to allow the user to control this externally without adding a new function property.

@sunnyyadav100
Copy link

Can this feature support auto-complete? It will we nice it supports auto-complete and allow custom values to add.

@MapTo0
Copy link
Member

MapTo0 commented Aug 13, 2020

Hello all,

Is the following API OK for you:

<ui5-multi-combobox filter="None" allow-custom-values>
  <ui5-mcb-item text="Item 1"></ui5-mcb-item>
  <ui5-mcb-item text="Item 2"></ui5-mcb-item>
  <ui5-mcb-item text="Item 3"></ui5-mcb-item>
</ui5-multi-combobox>

After that you can listen for input event and always define your items based on the value property.

Build in filters will be the following: StartsWith, StartsWithPerTerm, Contains, None

MapTo0 added a commit that referenced this issue Aug 13, 2020
Buildin filters are
 - StartsWithPerTerm
 - StartsWith
 - Contains
 - None

FIXES: #799
@Lukas742
Copy link
Collaborator Author

Hi @MapTo0

looks good to me. Thanks a lot!

MapTo0 added a commit that referenced this issue Nov 17, 2020
Build-in filters are

 - StartsWithPerTerm
 - StartsWith
 - Contains
 - None

Users can now set filter to None and filter when input event is fired

FIXES: #799
ndeshev pushed a commit to ndeshev/ui5-webcomponents that referenced this issue Nov 18, 2020
Build-in filters are

 - StartsWithPerTerm
 - StartsWith
 - Contains
 - None

Users can now set filter to None and filter when input event is fired

FIXES: SAP#799
ilhan007 pushed a commit that referenced this issue Nov 19, 2020
Build-in filters are

 - StartsWithPerTerm
 - StartsWith
 - Contains
 - None

Users can now set filter to None and filter when input event is fired

FIXES: #799
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants