Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui5-menu]: Active state text color on Menu item looks wrong in Fiori 3 theme #8681

Closed
1 task done
LidiyaGeorgieva opened this issue Apr 8, 2024 · 1 comment · Fixed by #8699
Closed
1 task done

[ui5-menu]: Active state text color on Menu item looks wrong in Fiori 3 theme #8681

LidiyaGeorgieva opened this issue Apr 8, 2024 · 1 comment · Fixed by #8699
Assignees
@unazko
Labels
ACC bug This issue is a bug in the code Low Prio TOPIC B

Comments

@LidiyaGeorgieva
Copy link
Contributor

LidiyaGeorgieva commented Apr 8, 2024 •
edited
Loading

Bug Description

Text does not have contrast from the background:
image

Affected Component

No response

Expected Behaviour

No response

Isolated Example

https://sap.github.io/ui5-webcomponents/nightly/components/Menu

Steps to Reproduce

  1. Change theme to Fiori 3 (Quartz Light)
  2. Open the basic sample
  3. Press on some menu item

Log Output, Stack Trace or Screenshots

No response

Priority

Low

UI5 Web Components Version

main

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@LidiyaGeorgieva LidiyaGeorgieva added the bug This issue is a bug in the code label Apr 8, 2024
@LidiyaGeorgieva LidiyaGeorgieva changed the title [ui5-menu]: Active state on Menu items looks wrong in Fiori 3 theme [ui5-menu]: Active state text color on Menu item looks wrong in Fiori 3 theme Apr 8, 2024
@niyap
Copy link
Contributor

niyap commented Apr 8, 2024

Hello @SAP/ui5-webcomponents-topic-b,

When the menu item is selected, it's icon color is changed to white but the text remains black. As a result, the requirement for contrast color ratio is not fulfilled.

Could you please look over?

Kind Regards,
Niya

@unazko unazko self-assigned this Apr 8, 2024
unazko added a commit to unazko/ui5-webcomponents that referenced this issue Apr 9, 2024
@unazko
fix(ui5-menu): adjust active menu item text color
2a22ede 
Related to: SAP#8681
@unazko unazko mentioned this issue Apr 9, 2024
Merged
unazko added a commit that referenced this issue Apr 10, 2024
@unazko
fix(ui5-menu): adjust active menu item text color (#8699)
1a7331d 
Related to: #8681
unazko added a commit to unazko/ui5-webcomponents that referenced this issue Apr 17, 2024
@unazko
fix(ui5-menu): adjust active menu item text color
e61a1ac 
Related to: SAP#8681
@unazko unazko mentioned this issue Apr 17, 2024
Merged
ilhan007 pushed a commit that referenced this issue Apr 22, 2024
@unazko
fix(ui5-menu): adjust active menu item text color (#8782)
0cf06f1 
Fixes: #8681
@petyabegovska petyabegovska moved this to Completed in Maintenance - Topic B Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unazko unazko

Labels
ACC bug This issue is a bug in the code Low Prio TOPIC B
Projects
Maintenance - Topic B
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-menu): adjust active menu item text color unazko/ui5-webcomponents
3 participants
@LidiyaGeorgieva @unazko @niyap