Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui5-input]: Change event is fired each time a suggestion is selected even if we re-select the current item #8912

Closed
1 task done
nikoletavnv opened this issue May 8, 2024 · 0 comments · Fixed by #9429
Assignees
Labels
bug This issue is a bug in the code Medium Prio TOPIC RL

Comments

@nikoletavnv
Copy link
Member

nikoletavnv commented May 8, 2024

Bug Description

When suggestions are enabled for ui5-input and the user selects a suggestion, a change event is fired. If the user modifies the text but before leaving the input decides to select the same suggestion again - change event is fired again, even when the input text is the same.

Affected Component

ui5-input

Expected Behaviour

Change event is fired only when the value modifications have finished and the new value differs from the previous one.

Isolated Example

Steps to Reproduce

...

Log Output, Stack Trace or Screenshots

ui5-input-change-event.mp4

Priority

None

UI5 Web Components Version

1.24

Browser

Chrome

Operating System

Windows

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@nikoletavnv nikoletavnv added bug This issue is a bug in the code TOPIC RL Medium Prio labels May 8, 2024
@petyabegovska petyabegovska moved this to New Issues in Maintenance - Topic RL Jun 21, 2024
@nikoletavnv nikoletavnv self-assigned this Jul 5, 2024
@nikoletavnv nikoletavnv moved this from New Issues to In progress in Maintenance - Topic RL Jul 5, 2024
nikoletavnv added a commit that referenced this issue Jul 9, 2024
Do not fire change event when the same suggestion item is reselected.

Fixes #8912
nikoletavnv added a commit that referenced this issue Jul 16, 2024
Do not fire change event when the same suggestion item is reselected.

Fixes #8912
@github-project-automation github-project-automation bot moved this from In progress to Completed in Maintenance - Topic RL Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio TOPIC RL
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

1 participant