Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table]: Table Column Label is displayed in bolder in Safari than in Chrome #9046

Closed
1 task done
lenafi5cher opened this issue May 22, 2024 · 3 comments
Closed
1 task done
Labels
bug This issue is a bug in the code Medium Prio TOPIC Core

Comments

@lenafi5cher
Copy link

Describe the bug

Similar to this issue, now the Labels for the TableColumns appear a lot bolder in Safari than in Chrome.

Isolated Example

No response

Reproduction steps

  1. Open the Table docs in Safari
  2. Look at the example

Expected Behaviour

Font size should be the same as shown in Chrome
image

Screenshots or Videos

image

UI5 Web Components for React Version

v1.28.1

UI5 Web Components Version

v1.24.0

Browser

Safari

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

SAP

Declaration

  • I’m not disclosing any internal or sensitive information.
@lenafi5cher lenafi5cher added the bug This issue is a bug in the code label May 22, 2024
@Lukas742
Copy link
Collaborator

Lukas742 commented May 22, 2024

Hi @lenafi5cher

our example currently uses the Label component for the header and cell text which is not according to the design guidelines. This PR will adjust the examples to use spans instead.

Unfortunately the issue persists even with span and as the Table is a web component developed by the UI5 Web Components team, I'm going to transfer the issue to their repo.


Hi colleagues,

additionally to what @lenafi5cher has found, the text boldness of the header columns differs in Firefox as well. You can see the difference in your examples.

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react May 22, 2024
@Todor-ads
Copy link
Member

Hello @SAP/ui5-webcomponents-topic-rl ,
Could you please look into this issue? The problem reproduces following the described steps.

Regards,
Todor

ilhan007 pushed a commit that referenced this issue Jul 9, 2024
"72-SemiboldDuplex", "72-SemiboldDuplexfull" fonts look broken in Safari browser when its font weight is set to bold.
With this the specification of ui5-table-column was updated and now, the column's font weight should be set to normal. With this PR the styles are align to the specification.

Fixes: #9046
nnaydenow added a commit that referenced this issue Jul 9, 2024
"72-SemiboldDuplex", "72-SemiboldDuplexfull" fonts look broken in Safari browser when its font weight is set to bold.
![image](https://github.com/SAP/ui5-webcomponents/assets/31909318/8b927aea-da58-4a73-916b-5ce8dd8ff91e)

With this the specification of `ui5-table-column` was updated and now, the column's font weight should be set to normal. With this PR the styles are align to the specification.

Related to: #9046
@nnaydenow
Copy link
Contributor

Fixed the issue for version 1.24 with #9418 and it will be available with the next patch. For version 2.0 and table inside @ui5/webcomponents-compat is fixed with #9417

@github-project-automation github-project-automation bot moved this from New to Completed in Maintenance - Topic Core Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio TOPIC Core
Projects
Status: Completed
Development

No branches or pull requests

5 participants