Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MessageStrip (v2.0.0-rc.5)]: changing design from value-states to color-set doesn't remove the icon #9181

Closed
1 task done
Lukas742 opened this issue Jun 11, 2024 · 1 comment · Fixed by #9229
Closed
1 task done
Assignees
Labels
bug This issue is a bug in the code TOPIC RL UI5_WEBC_4_REACT
Milestone

Comments

@Lukas742
Copy link
Collaborator

Bug Description

If the design property of a MessageStrip is changed from any value-state design to any color-set design, the default icon isn't removed.

Affected Component

MessageStrip

Expected Behaviour

No response

Isolated Example

https://stackblitz.com/edit/github-4hh5q2?file=package.json,index.html,main.js

Steps to Reproduce

  1. Go to StackBlitz
  2. Click on the button to change the design of the first two MessageStrips
  3. See that the icons of the MessageStrips aren't removed

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

v2.0.0-rc.5

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742 Lukas742 added the bug This issue is a bug in the code label Jun 11, 2024
@ilhan007
Copy link
Member

Hello @SAP/ui5-webcomponents-topic-rl there is a wrong state of the component when setting not initially but later-on.

When the following state is set later-on, f.e. in a click handler:

document.getElementById('btn').addEventListener('click', () => {
  strip.design = 'ColorSet1';
  strip.colorScheme = '1';
});

The default icon remains:
Screenshot 2024-06-12 at 13 13 54

The same is not displayed if we set the same props and values in the markup ( <ui5-message-strip design="ColorSet1" color-scheme="1"):
Screenshot 2024-06-12 at 13 13 58

@nikoletavnv nikoletavnv self-assigned this Jun 14, 2024
nikoletavnv added a commit that referenced this issue Jun 17, 2024
nikoletavnv added a commit that referenced this issue Jun 19, 2024
@ilhan007 ilhan007 added this to the 2.0.0 milestone Jun 20, 2024
nikoletavnv added a commit that referenced this issue Jun 20, 2024
#9229)

* fix(ui5-message-strip): changing design from value-states to color-set does remove the initial icon

Fixes #9181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code TOPIC RL UI5_WEBC_4_REACT
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants