Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui5-checkbox]: focus outline off in compact #9254

Closed
1 task done
ilhan007 opened this issue Jun 19, 2024 · 0 comments · Fixed by #9335
Closed
1 task done

[ui5-checkbox]: focus outline off in compact #9254

ilhan007 opened this issue Jun 19, 2024 · 0 comments · Fixed by #9335
Assignees
@kgogov
Labels
2.0 Release Testing bug This issue is a bug in the code Medium Prio TOPIC P

Comments

@ilhan007
Copy link
Member

ilhan007 commented Jun 19, 2024 •
edited
Loading

Bug Description

The focus outline is wrong, it goes over the check square part in compact content density:

Horizon, compact:

Screenshot 2024-06-19 at 12 14 38

Quartz, compact:

Screenshot 2024-06-19 at 12 27 45

Affected Component

No response

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

...

Log Output, Stack Trace or Screenshots

No response

Priority

Low | Medium

UI5 Web Components Version

nightly

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@ilhan007 ilhan007 added bug This issue is a bug in the code TOPIC P labels Jun 19, 2024
@kgogov kgogov assigned kgogov and unassigned dobrinyonkov Jun 20, 2024
@petyabegovska petyabegovska moved this to In Progress in Maintenance - Topic P Jun 21, 2024
@kgogov kgogov mentioned this issue Jun 27, 2024
Merged
kgogov added a commit that referenced this issue Jun 28, 2024
@kgogov
fix(ui5-checkbox): adjust focus outline in wrapped mode
f8e7e10 
This commit adjusts the focus outline in wrapped mode for the CheckBox
component. It address the initial concern that the focus outline was out
of place in compact density mode, but also improves the overall focus
outline in all density modes.

Themes that were checked:

- sap_horizon
- sap_horizon_dark
- sap_horizon_hcb
- sap_horizon_hcw
- sap_fiori_3
- sap_fiori_3_dark
- sap_fiori_3_hcb
- sap_fiori_3_hcw

Fixes: #9254
@kgogov kgogov mentioned this issue Jun 28, 2024
Merged
yanaminkova pushed a commit that referenced this issue Jul 2, 2024
@kgogov
fix(ui5-checkbox): adjust focus outline in wrapped mode (#9335)
13f87f5 
This commit adjusts the focus outline in wrapped mode for the CheckBox
component. It address the initial concern that the focus outline was out
of place in compact density mode, but also improves the overall focus
outline in all density modes.

Themes that were checked:

- sap_horizon
- sap_horizon_dark
- sap_horizon_hcb
- sap_horizon_hcw
- sap_fiori_3
- sap_fiori_3_dark
- sap_fiori_3_hcb
- sap_fiori_3_hcw

Fixes: #9254
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Maintenance - Topic P Jul 2, 2024
ilhan007 pushed a commit that referenced this issue Jul 11, 2024
@kgogov
fix(ui5-checkbox): adjust focus outline in wrapped mode (#9330)
31fd31a 
This commit adjusts the focus outline in wrapped mode for the CheckBox component. It address the initial concern that the focus outline was out of place in compact density mode, but also improves the overall focus outline in all density modes.

Fixes: #9254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kgogov kgogov

Labels
2.0 Release Testing bug This issue is a bug in the code Medium Prio TOPIC P
Projects
Maintenance - Topic P
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-checkbox): adjust focus outline in wrapped mode SAP/ui5-webcomponents
3 participants
@ilhan007 @dobrinyonkov @kgogov