Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[input like]: remove cloneNode from valueStateMessage slot #9347

Closed
5 tasks done
nnaydenow opened this issue Jul 1, 2024 · 2 comments
Closed
5 tasks done

[input like]: remove cloneNode from valueStateMessage slot #9347

nnaydenow opened this issue Jul 1, 2024 · 2 comments
Assignees
@hinzzx
Labels
enhancement New feature or request TOPIC B TOPIC P TOPIC RD TOPIC RL

Comments

@nnaydenow
Copy link
Contributor

nnaydenow commented Jul 1, 2024 •
edited by hinzzx
Loading

Bug Description

Before, the valueStateMessage slot content had to be cloned because the content was rendered outside of the component in the ui5-popover inside ui5-static-area. With the integration of Popover API, the ui5-popover is placed inside the shadow root of the component, eliminating the need for the clone.

Affected Component

ui5-combobox, ui5-file-uploader, ui5-multi-combobox, ui5-select, ui5-textarea

Expected Behaviour

Instead of node cloning use <slot name="valueStateMessage"></slot>
@nnaydenow
Copy link
Contributor Author

Hello @SAP/ui5-webcomponents-topic-b, @SAP/ui5-webcomponents-topic-rl, @SAP/ui5-webcomponents-topic-p, @SAP/ui5-webcomponents-topic-rd,

Please take a look at this enhancement.

@ndeshev ndeshev self-assigned this Jul 3, 2024
ndeshev added a commit that referenced this issue Jul 3, 2024
@ndeshev
fix(ui5-combobox): remove the cloning of the value state message
6726d60 
related to #9347
@ndeshev ndeshev mentioned this issue Jul 3, 2024
Merged
ndeshev added a commit that referenced this issue Jul 4, 2024
@ndeshev
fix(ui5-multi-combobox): remove the cloning of the value state message
c509dfe 
related to: #9347
@ndeshev ndeshev mentioned this issue Jul 4, 2024
Merged
@nikoletavnv nikoletavnv moved this from New Issues to In progress in Maintenance - Topic RL Jul 5, 2024
ndeshev added a commit that referenced this issue Jul 5, 2024
@ndeshev
fix(ui5-textarea): remove the cloning of the value state message
ed640a4 
related to: #9347
@ndeshev ndeshev mentioned this issue Jul 5, 2024
Merged
ndeshev added a commit that referenced this issue Jul 5, 2024
@ndeshev
fix(ui5-multi-combobox): remove the cloning of the value state message (
68ea4af 
#9391)

* fix(ui5-multi-combobox): remove the cloning of the value state message

related to: #9347
@dobrinyonkov
Copy link
Contributor

Internal Reference: BGSOFUIPIRIN-6611

ndeshev added a commit that referenced this issue Jul 5, 2024
@ndeshev
fix(ui5-textarea): remove the cloning of the value state message (#9401)
185d598 
* fix(ui5-textarea): remove the cloning of the value state message

related to: #9347
ndeshev added a commit that referenced this issue Jul 16, 2024
@ndeshev
fix(ui5-combobox): remove the cloning of the value state message (#9384)
a24c6b7 
* fix(ui5-combobox): remove the cloning of the value state message

related to #9347
@ndeshev ndeshev moved this from In progress to Completed in Maintenance - Topic RL Jul 17, 2024
@ndeshev ndeshev removed their assignment Jul 17, 2024
plamenivanov91 added a commit to plamenivanov91/ui5-webcomponents that referenced this issue Aug 7, 2024
@plamenivanov91
fix(ui5-select): remove the cloning of the value state message
3fe2580 
related to SAP#9347
@plamenivanov91 plamenivanov91 mentioned this issue Aug 7, 2024
Merged
plamenivanov91 added a commit that referenced this issue Aug 7, 2024
@plamenivanov91
fix(ui5-select): remove the cloning of the value state message (#9654)
1466076 
related to #9347
@hinzzx hinzzx self-assigned this Sep 20, 2024
@hinzzx hinzzx mentioned this issue Sep 20, 2024
Merged
@github-project-automation github-project-automation bot moved this from New Issues to Completed in Maintenance - Topic RD Oct 29, 2024
@github-project-automation github-project-automation bot moved this from New to Completed in Planning - Topic P Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hinzzx hinzzx

Labels
enhancement New feature or request TOPIC B TOPIC P TOPIC RD TOPIC RL
Projects
Maintenance - Topic RD
Status: Completed
Maintenance - Topic RL
Status: Completed
Planning - Topic P
Status: Completed
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ndeshev @dobrinyonkov @nnaydenow @hinzzx