Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FlexibleColumnLayout]: missing import for icon "vertical-grip" #9534

Closed
1 task done
camelCaseChris opened this issue Jul 22, 2024 · 4 comments
Closed
1 task done
Assignees
Labels
bug This issue is a bug in the code Medium Prio TOPIC P

Comments

@camelCaseChris
Copy link

Bug Description

The FlexibleColumnLayout uses icon vertical-grip but does not import it. The result are several console errors and the icon is missing.

You can reproduce this in the basic sample of the component documention. Open https://sap.github.io/ui5-webcomponents/components/fiori/FlexibleColumnLayout/#basic-sample and open the console. You will see errors like "No loader registered for the SAP-icons-v5 icons collection. Probably you forgot to import the "AllIcons.js" module for the respective package." Also, when you select a supplier from the list so that the second column expands, you will see that the icon is missing in the column separator.

(PS: it seems strange that the error suggests using the AllIcons.js import. Is importing individual icons not the more usual use-case?)

Affected Component

FlexibleColumnLayout

Expected Behaviour

A component should import all icons it uses.

Isolated Example

See bug description.

Steps to Reproduce

See bug description.

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

2.0.1

Browser

Chrome, Firefox

Operating System

Win11

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@camelCaseChris camelCaseChris added the bug This issue is a bug in the code label Jul 22, 2024
@kgogov kgogov self-assigned this Jul 22, 2024
@kgogov
Copy link
Member

kgogov commented Jul 22, 2024

Hello @camelCaseChris,

Thank you for sharing this finding.
I am forwarding this ticket to the responsible team, who will look into it and assist.

@SAP/ui5-webcomponents-topic-p, could you please look into this?

Regards,
Konstantin Gogov
UI5 Web Components GitHub Dispatcher

@kineticjs
Copy link
Contributor

Hi colleagues,

This issue was recently fixed with 1be8d6c

@kineticjs
Copy link
Contributor

@kgogov pointed out offline that despite that the icon is now visualised (as we see from the nightly version: https://sap.github.io/ui5-webcomponents/nightly/components/fiori/FlexibleColumnLayout/ ) the additional issue with the console error is still there, so we will take this for further inspection.

@dobrinyonkov dobrinyonkov self-assigned this Aug 1, 2024
@dobrinyonkov dobrinyonkov moved this from Issues to In Progress in Maintenance - Topic P Aug 1, 2024
ilhan007 pushed a commit that referenced this issue Aug 2, 2024
An icon used by the shellbar template was not imported as dependecy.
Additionally the FCL's sample was also using some icons that were not imported in the JS file.

Closes: #9580, #9534
ilhan007 pushed a commit that referenced this issue Aug 2, 2024
An icon used by the shellbar template was not imported as dependecy.
Additionally the FCL's sample was also using some icons that were not imported in the JS file.

Closes: #9580, #9534
dobrinyonkov added a commit that referenced this issue Aug 5, 2024
An icon used by the shellbar template was not imported as dependecy.
Additionally the FCL's sample was also using some icons that were not imported in the JS file.

Closes: #9580, #9534
ilhan007 pushed a commit that referenced this issue Aug 5, 2024
An icon used by the shellbar template was not imported as dependency. Additionally the FCL's sample was also using some icons that were not imported in the JS file.

Fixes: #9580
Fixes: #9534
@dobrinyonkov
Copy link
Contributor

Closed by #9637

@github-project-automation github-project-automation bot moved this from In Progress to Completed in Maintenance - Topic P Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio TOPIC P
Projects
Status: Completed
Development

No branches or pull requests

4 participants