-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FlexibleColumnLayout]: missing import for icon "vertical-grip" #9534
Comments
Hello @camelCaseChris, Thank you for sharing this finding. @SAP/ui5-webcomponents-topic-p, could you please look into this? Regards, |
Hi colleagues, This issue was recently fixed with 1be8d6c |
@kgogov pointed out offline that despite that the icon is now visualised (as we see from the nightly version: https://sap.github.io/ui5-webcomponents/nightly/components/fiori/FlexibleColumnLayout/ ) the additional issue with the console error is still there, so we will take this for further inspection. |
Closed by #9637 |
Bug Description
The FlexibleColumnLayout uses icon
vertical-grip
but does not import it. The result are several console errors and the icon is missing.You can reproduce this in the basic sample of the component documention. Open https://sap.github.io/ui5-webcomponents/components/fiori/FlexibleColumnLayout/#basic-sample and open the console. You will see errors like "No loader registered for the SAP-icons-v5 icons collection. Probably you forgot to import the "AllIcons.js" module for the respective package." Also, when you select a supplier from the list so that the second column expands, you will see that the icon is missing in the column separator.
(PS: it seems strange that the error suggests using the AllIcons.js import. Is importing individual icons not the more usual use-case?)
Affected Component
FlexibleColumnLayout
Expected Behaviour
A component should import all icons it uses.
Isolated Example
See bug description.
Steps to Reproduce
See bug description.
Log Output, Stack Trace or Screenshots
No response
Priority
Medium
UI5 Web Components Version
2.0.1
Browser
Chrome, Firefox
Operating System
Win11
Additional Context
No response
Organization
No response
Declaration
The text was updated successfully, but these errors were encountered: