fix(ui5-card): fix accessibiity role position #10437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
reviewed
Dec 23, 2024
| @@ -124,6 +124,28 @@ describe("CardHeader", () => { | |||
| assert.strictEqual(await header2.getAttribute("aria-labelledby"), EXPECTED_ARIA_LABELLEDBY_HEADER2, | |||
| "The aria-labelledby is correctly set."); | |||
| }); | |||
|
|
|||
| it("test interactive card header accessibility role", async () => { | |||
There was a problem hiding this comment.
Let's write these tests in Cypress, as we are going to nevertheless migrate all the wdio tests to Cypress.
ilhan007
reviewed
Dec 27, 2024
| cy.get("#cardHeader1") | ||
| .shadow() | ||
| .find(".ui5-card-header-focusable-element") | ||
| .should("have.attr", "role", "button"); |
There was a problem hiding this comment.
We can combine these assertions as they are called on the same element
cy.get("#cardHeader1")
.shadow()
.find(".ui5-card-header-focusable-element")
.should("have.attr", "role", "button")
.and("have.attr", "tabindex", "0")
.and("have.attr", "aria-roledescription", "Interactive Card Header");Same for the second test
ilhan007
approved these changes
Jan 22, 2025
|
🎉 This PR is included in version v2.7.0-rc.1 🎉 The release is available on v2.7.0-rc.1 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX: #10367