New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-side-navigation): add actions and unselectable items #10482

Merged

dimovpetar merged 32 commits into main from side_navigation_actions_leaves

Jan 27, 2025

Contributor

dimovpetar commented Jan 7, 2025

BGSOFUIRODOPI-3344


          feat(ui5-side-navigation): add actions and option to select leaves only

ef74d27

dimovpetar marked this pull request as draft

January 7, 2025 13:27

dimovpetar added 10 commits

January 13, 2025 10:56


          refactor: use unselectable instead of interaction mode

a27775e


          test: isSelectable

22257c0


          feat: all parts of unselectable items now can toggle them

4adbd21


          test: reorder tests

1503d1d


          test: proper assertion

d8fc7b7


          feat: add ariaAttributes with hasPopup

a9116a3


          test: correct indexes

9cdeaa9


          docs: annotate new properties

1afccc5


          Merge branch 'main' of github.com:SAP/ui5-webcomponents into side_nav…

4f21684

…igation_actions_leaves


          fix: export SideNavigationItemAccessibilityAttributes

fb131e1

dimovpetar marked this pull request as ready for review

January 14, 2025 08:25

dimovpetar changed the title ~~feat(ui5-side-navigation): add actions and option to select leaves only~~ feat(ui5-side-navigation): add actions and unselectable items

dimovpetar added 5 commits

January 14, 2025 13:42


          test: add tests for selection-change event

c944047


          docs: add sample

6d86a32


          fix: toggle unselectable items with keyboard

f926cc8


          docs: document restriction not to use subitems with actions

f50bac7


          Merge branch 'main' of github.com:SAP/ui5-webcomponents into side_nav…

1112cf5

…igation_actions_leaves

dimovpetar requested review from a team and Stoev

January 14, 2025 14:13

Stoev reviewed

View reviewed changes

Stoev left a comment

As tentative suggestion please consider changing summary sentence "feat(ui5-side-navigation): add actions and unselectable items #10482" to "feat(ui5-side-navigation): adds actions and unselectable items #10482".

Reason for suggestion proposal is: https://github.com/SAP/openui5/blob/master/docs/guidelines/jsdoc.md - JSDoc Guidelines: "For actions, start directly with an appropriate verb in the third person: Adds, allocates, constructs, converts, deallocates, destroys, gets, provides, reads, removes, represents, returns, sets, saves, and so on".

packages/fiori/src/SideNavigationSelectableItemBase.ts Outdated Show resolved Hide resolved

packages/fiori/src/SideNavigationSelectableItemBase.ts Show resolved Hide resolved

packages/fiori/src/SideNavigationSelectableItemBase.ts Outdated Show resolved Hide resolved

packages/fiori/src/types/SideNavigationItemDesign.ts Outdated Show resolved Hide resolved


          docs: improve documentation

31fb11a

Contributor Author

dimovpetar commented Jan 20, 2025

As tentative suggestion please consider changing summary sentence "feat(ui5-side-navigation): add actions and unselectable items #10482" to "feat(ui5-side-navigation): adds actions and unselectable items #10482".

Reason for suggestion proposal is: https://github.com/SAP/openui5/blob/master/docs/guidelines/jsdoc.md - JSDoc Guidelines: "For actions, start directly with an appropriate verb in the third person: Adds, allocates, constructs, converts, deallocates, destroys, gets, provides, reads, removes, represents, returns, sets, saves, and so on".

This is the guideline that applies here https://sap.github.io/ui5-webcomponents/docs/contributing/conventions-and-guidelines/#commit-description. It should be in imperative present tense.

dimovpetar requested a review from Stoev

January 20, 2025 08:14

alexandar-mitsev requested changes

View reviewed changes

packages/fiori/src/SideNavigationSelectableItemBase.ts Show resolved Hide resolved

packages/website/docs/_components_pages/fiori/SideNavigation/SideNavigation.mdx Show resolved Hide resolved

packages/website/docs/_samples/fiori/SideNavigation/QuickAction/main.js Outdated Show resolved Hide resolved

packages/fiori/src/SideNavigationItem.ts Show resolved Hide resolved

packages/fiori/src/SideNavigationItem.ts Outdated Show resolved Hide resolved

packages/fiori/src/SideNavigationSelectableItemBase.ts Show resolved Hide resolved

packages/fiori/src/SideNavigationSelectableItemBase.ts Show resolved Hide resolved

alexandar-mitsev reviewed

View reviewed changes

packages/fiori/src/SideNavigationItemTemplate.tsx Outdated Show resolved Hide resolved

dimovpetar added 2 commits

January 21, 2025 13:25


          fix: properly fire selection-change from in collapsed mode


          fix: forward design attribute to items in collapsed mode

8adc31a

dimovpetar added 7 commits

January 21, 2025 16:17


          fix: aria-haspopup is now added in collapsed mode

e3e99f1


          fix: don't toggle expanded property on leaf nodes

4cc9f56


          fix: fire click event on Enter

1d15c74


          fix: set role to menuitem for unselectable items

564a6df


          docs: improve unselectable description


          docs: make all external links unselectable

216db08


          docs: replace alert with ui5-dialog

a4993ef

alexandar-mitsev requested changes

View reviewed changes

packages/fiori/src/SideNavigationSelectableItemBase.ts Outdated Show resolved Hide resolved

packages/fiori/src/SideNavigationSelectableItemBase.ts Show resolved Hide resolved

packages/fiori/src/SideNavigationItem.ts Show resolved Hide resolved

packages/fiori/src/SideNavigationSelectableItemBase.ts Show resolved Hide resolved

Stoev reviewed

View reviewed changes

Stoev left a comment

please consider some suggestions.

packages/fiori/src/SideNavigationSelectableItemBase.ts Outdated Show resolved Hide resolved

packages/fiori/src/SideNavigationSelectableItemBase.ts Outdated Show resolved Hide resolved

packages/fiori/src/SideNavigationSelectableItemBase.ts Show resolved Hide resolved

packages/fiori/src/SideNavigationSelectableItemBase.ts Outdated Show resolved Hide resolved

packages/fiori/src/SideNavigationSelectableItemBase.ts Outdated Show resolved Hide resolved

alexandar-mitsev added 2 commits

January 24, 2025 09:14


          docs: improve documentation

df8e6ef


          Merge branch 'main' into side_navigation_actions_leaves

667f1f8

alexandar-mitsev approved these changes

View reviewed changes

packages/fiori/src/SideNavigationItem.ts Show resolved Hide resolved

alexandar-mitsev added 4 commits

January 27, 2025 08:33


          Merge branch 'main' into side_navigation_actions_leaves

c6c4004


          test: fix focusing for navigation items

4abeacb


          fix: revert fix of focusing items

bf899bc


          fix: fix commands and selection for focus

7fe12de

dimovpetar requested a review from Stoev

January 27, 2025 09:32

dimovpetar merged commit 9fb9bae into main

10 checks passed

dimovpetar deleted the side_navigation_actions_leaves branch

January 27, 2025 09:43

Stoev reviewed

View reviewed changes

Stoev left a comment

OK from UA perspective. Thank you.

Collaborator

ui5-webcomponents-bot commented Jan 30, 2025

🎉 This PR is included in version v2.7.0-rc.2 🎉

The release is available on v2.7.0-rc.2

Your semantic-release bot 📦🚀

ui5-webcomponents-bot added the released label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels