chore(ui5-media-gallery): migrate to jsx template #10614
+83
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kineticjs
force-pushed
the
media-gallery-jsx-template
branch
from
a59a4f1 to
849f195
Compare
ilhan007
reviewed
Jan 22, 2025
| > | ||
| <div class="ui5-media-gallery-item-mask-layer"></div> | ||
| <div class="ui5-media-gallery-item-wrapper" style={this.styles.wrapper}> | ||
| {this._showBackgroundIcon && <Icon name="background"></Icon>} |
There was a problem hiding this comment.
One new thing around the migration is that we also encourage importing the used icons in the template
and make use of its default export to bind it:
import background from "@ui5/webcomponents-icons/dist/background.js";
<Icon name={background}></Icon>This way we will avoid icons missed to be imported, because using the hardcoded string does not have relation to the import.
*afterwards, you can remove the import from the MGitem class
ilhan007
reviewed
Jan 22, 2025
| {this._isPhonePlatform | ||
| ? <Carousel | ||
| onNavigate={this._onCarouselNavigate} | ||
| hideNavigationArrows |
There was a problem hiding this comment.
really minor - explicitly setting to true is recommended => hideNavigationArrows={true}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.